Fix pylint and pep8 issues

Signed-off-by: Cole Robinson <crobinso@redhat.com>

Author: crobinso

.pylintrc

@@ -7,7 +7,7 @@ persistent=no
 # can either give multiple identifier separated by comma (,) or put this option
 # multiple time (only on the command line, not in the configuration file where
 # it should appear only once).
-disable=Design,Format,Similarities,invalid-name,missing-docstring,locally-disabled,unnecessary-lambda,star-args,fixme,global-statement,broad-except,no-self-use,bare-except,locally-enabled,wrong-import-position,consider-using-ternary,len-as-condition,no-else-return,useless-object-inheritance,inconsistent-return-statements,consider-using-dict-comprehension,import-outside-toplevel,use-a-generator,consider-using-with,consider-using-f-string,unspecified-encoding
+disable=Design,Format,Similarities,invalid-name,missing-docstring,locally-disabled,unnecessary-lambda,fixme,global-statement,broad-except,bare-except,wrong-import-position,consider-using-ternary,len-as-condition,no-else-return,useless-object-inheritance,inconsistent-return-statements,consider-using-dict-comprehension,import-outside-toplevel,use-a-generator,consider-using-with,consider-using-f-string,unspecified-encoding
 enable=fixme
 
 

bugzilla/_cli.py

@@ -1047,7 +1047,7 @@ def _do_modify(bz, parser, opt):
 
     for k, v in wbmap.copy().items():
         if not v[0] and not v[1]:
-            del(wbmap[k])
+            del wbmap[k]
 
     if opt.fields:
         _merge_field_opts(update, opt.fields, parser)

bugzilla/_session.py

@@ -31,7 +31,7 @@ def __init__(self, url, user_agent,
         self._use_auth_bearer = False
 
         if self._scheme not in ["http", "https"]:
-            raise Exception("Invalid URL scheme: %s (%s)" % (
+            raise ValueError("Invalid URL scheme: %s (%s)" % (
                 self._scheme, url))
 
         self._session = requests_session

bugzilla/base.py

@@ -1302,7 +1302,7 @@ def add_email(key, value, count):
         # Strip out None elements in the dict
         for k, v in query.copy().items():
             if v is None:
-                del(query[k])
+                del query[k]
 
         self.pre_translation(query)
         return query
@@ -1799,7 +1799,7 @@ def _validate_createbug(self, *args, **kwargs):
 
         # Back compat handling for check_args
         if "check_args" in data:
-            del(data["check_args"])
+            del data["check_args"]
 
         return data
 

bugzilla/bug.py

@@ -136,7 +136,7 @@ def _translate_dict(self, newdict):
                           "d[%s]=%s and d[%s]=%s , dropping the value "
                           "d[%s]", newname, newdict[newname], oldname,
                         newdict[oldname], oldname)
-            del(newdict[oldname])
+            del newdict[oldname]
 
 
     def _update_dict(self, newdict):

tests/test_api_authfiles.py

@@ -26,7 +26,7 @@ def test_tokenfile(monkeypatch):
     token = dirname + "/data/homedir/.cache/python-bugzilla/bugzillatoken"
 
     assert token == bz.tokenfile
-    del(bz.tokenfile)
+    del bz.tokenfile
     assert bz.tokenfile is None
     assert bz.cookiefile is None
 
@@ -96,7 +96,7 @@ def _write(c):
 
     # Test confipath overwrite
     assert [temp.name] == bzapi.configpath
-    del(bzapi.configpath)
+    del bzapi.configpath
     assert [] == bzapi.configpath
     bzapi.readconfig()
     _check(None, None, None, None)

tests/test_api_bug.py

@@ -106,7 +106,7 @@ def test_bug_getattr():
 
     bug.autorefresh = True
     summary = bug.summary
-    del(bug.__dict__["summary"])
+    del bug.__dict__["summary"]
     # Trigger autorefresh
     assert bug.summary == summary
 

tests/test_api_misc.py

@@ -164,6 +164,7 @@ def testStandardQuery():
     }
     assert bz4.url_to_query(url) == query
 
+    # pylint: disable=use-implicit-booleaness-not-comparison
     # Test with unknown URL
     assert bz4.url_to_query("https://example.com") == {}
 

tests/test_rw_functional.py

@@ -363,6 +363,7 @@ def cleardict_new(b):
         bz.update_flags(bug2.id, cleardict_new(bug2))
     bug2.refresh()
 
+    # pylint: disable=use-implicit-booleaness-not-comparison
     assert cleardict_old(bug1) == {}
     assert cleardict_old(bug2) == {}