From d7e59a5ca5d78b147d28c3679a5b2eddbd9f3bc8 Mon Sep 17 00:00:00 2001 From: nekketsuuu Date: Thu, 11 Dec 2025 17:27:35 +0900 Subject: [PATCH 1/2] fix: $RS is not defined `$RS` is defined in `English` module. I suppose that `$RS` is introduced here for Style/SpecialGlobalVars cop of RuboCop, but the module is not required here. Instead of using the input record separator, this patch uses the NUL character as a separator. --- bootboot.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootboot.gemspec b/bootboot.gemspec index de13055..80afc19 100644 --- a/bootboot.gemspec +++ b/bootboot.gemspec @@ -25,7 +25,7 @@ Gem::Specification.new do |spec| spec.metadata["changelog_uri"] = "https://github.com/Shopify/bootboot/blob/master/CHANGELOG.md" spec.metadata["allowed_push_host"] = "https://rubygems.org" - spec.files = %x(git ls-files lib plugins.rb README.md LICENSE.txt).split($RS) + spec.files = %x(git ls-files -z lib plugins.rb README.md LICENSE.txt).split("\x0") spec.extra_rdoc_files = ["LICENSE.txt", "README.md"] spec.require_paths = ["lib"] From 136e746b1de1947fc6c808715f72d99b1f1f4418 Mon Sep 17 00:00:00 2001 From: Takuma Ishikawa Date: Sat, 13 Dec 2025 11:33:24 +0900 Subject: [PATCH 2/2] refactor: Stop using git command in gemspec since this is a small project Co-authored-by: Edouard CHIN --- bootboot.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bootboot.gemspec b/bootboot.gemspec index 80afc19..055cb79 100644 --- a/bootboot.gemspec +++ b/bootboot.gemspec @@ -25,7 +25,7 @@ Gem::Specification.new do |spec| spec.metadata["changelog_uri"] = "https://github.com/Shopify/bootboot/blob/master/CHANGELOG.md" spec.metadata["allowed_push_host"] = "https://rubygems.org" - spec.files = %x(git ls-files -z lib plugins.rb README.md LICENSE.txt).split("\x0") + spec.files = Dir["lib/**/*", "LICENSE.txt", "README.md", "plugins.rb"] spec.extra_rdoc_files = ["LICENSE.txt", "README.md"] spec.require_paths = ["lib"]