-
Notifications
You must be signed in to change notification settings - Fork 73
[SYNPY-1674]: Implement Form #1288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
synapseclient/models/mixins/form.py
Outdated
|
|
||
|
|
||
| @dataclass | ||
| class SubmissionStatus: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may conflict with submissions status that jenny is working on - unless it's using the same model. I would coordinate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@linglp I looked at the API, and one easy way to resolve this is to just do something like FormSubmissionStatus
Just a suggestion, but I'll let you and Jenny decide together
Notice the subtle difference:
- org.sagebionetworks.repo.model.SubmissionStatus
- org.sagebionetworks.repo.model.form.SubmissionStatus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tom. It makes sense to rename this class to FormSubmissionStatus!
Problem:
Implement the following endpoints: