From ae63c814df29b5895826c1188fca26fa729a39af Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Tue, 2 Dec 2025 14:35:06 -0700 Subject: [PATCH 1/6] always log warning --- synapseclient/client.py | 1 + 1 file changed, 1 insertion(+) diff --git a/synapseclient/client.py b/synapseclient/client.py index dfd3bb1e8..3da4a4524 100644 --- a/synapseclient/client.py +++ b/synapseclient/client.py @@ -1833,6 +1833,7 @@ def _check_entity_restrictions( Raises: SynapseUnmetAccessRestrictions: Warning for unmet access requirements. """ + self.logger.warning("Warning Raised") restriction_information = bundle.get("restrictionInformation", None) if restriction_information and restriction_information.get( "hasUnmetAccessRequirement", None From 5a699ac94f6386294cff3bcf786b6b8046c356c9 Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Tue, 2 Dec 2025 14:35:45 -0700 Subject: [PATCH 2/6] check assert called with --- tests/unit/synapseclient/unit_test_client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/synapseclient/unit_test_client.py b/tests/unit/synapseclient/unit_test_client.py index 209bf4e8f..c77a9ecd6 100644 --- a/tests/unit/synapseclient/unit_test_client.py +++ b/tests/unit/synapseclient/unit_test_client.py @@ -1184,7 +1184,7 @@ def test_check_entity_restrictions_no_unmet_restriction(self) -> None: } entity = "syn123" self.syn._check_entity_restrictions(bundle, entity, True) - mocked_warn.assert_not_called() + mocked_warn.assert_called_with("Warning Raised") def test_check_entity_restrictions_unmet_restriction_entity_file_with_download_file_is_true( self, From 6d5f04ebf7731a6a31f1f7cfd8743b43eba29e59 Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Tue, 2 Dec 2025 14:39:51 -0700 Subject: [PATCH 3/6] patch object on class instance --- tests/unit/synapseclient/unit_test_client.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/synapseclient/unit_test_client.py b/tests/unit/synapseclient/unit_test_client.py index c77a9ecd6..198498b4f 100644 --- a/tests/unit/synapseclient/unit_test_client.py +++ b/tests/unit/synapseclient/unit_test_client.py @@ -1172,7 +1172,7 @@ def init_syn(self, syn: Synapse) -> None: self.syn.credentials = SynapseAuthTokenCredentials(token="abc", username="def") def test_check_entity_restrictions_no_unmet_restriction(self) -> None: - with patch("logging.Logger.warning") as mocked_warn: + with patch.object(self.syn.logger, "warning") as mocked_warn: bundle = { "entity": { "id": "syn123", From 91d88c6ae9b382c57c2b6ef5cd4cd278bcc89dd3 Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Tue, 2 Dec 2025 14:43:43 -0700 Subject: [PATCH 4/6] Revert "always log warning" This reverts commit ae63c814df29b5895826c1188fca26fa729a39af. --- synapseclient/client.py | 1 - 1 file changed, 1 deletion(-) diff --git a/synapseclient/client.py b/synapseclient/client.py index 3da4a4524..dfd3bb1e8 100644 --- a/synapseclient/client.py +++ b/synapseclient/client.py @@ -1833,7 +1833,6 @@ def _check_entity_restrictions( Raises: SynapseUnmetAccessRestrictions: Warning for unmet access requirements. """ - self.logger.warning("Warning Raised") restriction_information = bundle.get("restrictionInformation", None) if restriction_information and restriction_information.get( "hasUnmetAccessRequirement", None From 3de00790177b5e87211fc423dfe75ef77dd7d1fb Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Tue, 2 Dec 2025 14:45:37 -0700 Subject: [PATCH 5/6] update patch target --- tests/unit/synapseclient/unit_test_client.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/unit/synapseclient/unit_test_client.py b/tests/unit/synapseclient/unit_test_client.py index 198498b4f..c2140babb 100644 --- a/tests/unit/synapseclient/unit_test_client.py +++ b/tests/unit/synapseclient/unit_test_client.py @@ -1184,12 +1184,11 @@ def test_check_entity_restrictions_no_unmet_restriction(self) -> None: } entity = "syn123" self.syn._check_entity_restrictions(bundle, entity, True) - mocked_warn.assert_called_with("Warning Raised") def test_check_entity_restrictions_unmet_restriction_entity_file_with_download_file_is_true( self, ) -> None: - with patch("logging.Logger.warning") as mocked_warn: + with patch.object(self.syn.logger, "warning") as mocked_warn: bundle = { "entity": { "id": "syn123", From f730271d8060f7d53127f54a2db5678e24198a82 Mon Sep 17 00:00:00 2001 From: GiaJordan Date: Wed, 3 Dec 2025 08:58:25 -0700 Subject: [PATCH 6/6] re-add erroneously removed line --- tests/unit/synapseclient/unit_test_client.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/unit/synapseclient/unit_test_client.py b/tests/unit/synapseclient/unit_test_client.py index c2140babb..57142e5bc 100644 --- a/tests/unit/synapseclient/unit_test_client.py +++ b/tests/unit/synapseclient/unit_test_client.py @@ -1184,6 +1184,7 @@ def test_check_entity_restrictions_no_unmet_restriction(self) -> None: } entity = "syn123" self.syn._check_entity_restrictions(bundle, entity, True) + mocked_warn.assert_not_called() def test_check_entity_restrictions_unmet_restriction_entity_file_with_download_file_is_true( self,