remove unnecessary imports and add style

Author: jaymedina

tests/integration/synapseclient/models/async/test_submission_bundle_async.py

@@ -7,7 +7,14 @@
 
 from synapseclient import Synapse
 from synapseclient.core.exceptions import SynapseHTTPError
-from synapseclient.models import Evaluation, File, Project, Submission, SubmissionBundle, SubmissionStatus
+from synapseclient.models import (
+    Evaluation,
+    File,
+    Project,
+    Submission,
+    SubmissionBundle,
+    SubmissionStatus,
+)
 
 
 class TestSubmissionBundleRetrievalAsync:
@@ -52,7 +59,9 @@ async def test_file(
         syn: Synapse,
         schedule_for_cleanup: Callable[..., None],
     ) -> File:
-        file_content = f"Test file content for submission bundle async tests {uuid.uuid4()}"
+        file_content = (
+            f"Test file content for submission bundle async tests {uuid.uuid4()}"
+        )
         with open("test_file_for_submission_bundle_async.txt", "w") as f:
             f.write(file_content)
 
@@ -192,9 +201,15 @@ async def test_get_evaluation_submission_bundles_with_pagination_async(
 
         # AND the bundle IDs should not overlap if we have enough submissions
         if len(bundles_page1) == 2 and len(bundles_page2) > 0:
-            page1_ids = {bundle.submission.id for bundle in bundles_page1 if bundle.submission}
-            page2_ids = {bundle.submission.id for bundle in bundles_page2 if bundle.submission}
-            assert page1_ids.isdisjoint(page2_ids), "Pages should not have overlapping submissions"
+            page1_ids = {
+                bundle.submission.id for bundle in bundles_page1 if bundle.submission
+            }
+            page2_ids = {
+                bundle.submission.id for bundle in bundles_page2 if bundle.submission
+            }
+            assert page1_ids.isdisjoint(
+                page2_ids
+            ), "Pages should not have overlapping submissions"
 
     async def test_get_evaluation_submission_bundles_invalid_evaluation_async(self):
         """Test getting submission bundles for invalid evaluation ID using async methods."""
@@ -267,9 +282,15 @@ async def test_get_user_submission_bundles_with_pagination_async(
 
         # AND the bundle IDs should not overlap if we have enough submissions
         if len(bundles_page1) == 2 and len(bundles_page2) > 0:
-            page1_ids = {bundle.submission.id for bundle in bundles_page1 if bundle.submission}
-            page2_ids = {bundle.submission.id for bundle in bundles_page2 if bundle.submission}
-            assert page1_ids.isdisjoint(page2_ids), "Pages should not have overlapping submissions"
+            page1_ids = {
+                bundle.submission.id for bundle in bundles_page1 if bundle.submission
+            }
+            page2_ids = {
+                bundle.submission.id for bundle in bundles_page2 if bundle.submission
+            }
+            assert page1_ids.isdisjoint(
+                page2_ids
+            ), "Pages should not have overlapping submissions"
 
 
 class TestSubmissionBundleDataIntegrityAsync:
@@ -314,7 +335,9 @@ async def test_file(
         syn: Synapse,
         schedule_for_cleanup: Callable[..., None],
     ) -> File:
-        file_content = f"Test file content for data integrity async tests {uuid.uuid4()}"
+        file_content = (
+            f"Test file content for data integrity async tests {uuid.uuid4()}"
+        )
         with open("test_file_for_data_integrity_async.txt", "w") as f:
             f.write(file_content)
 
@@ -410,7 +433,9 @@ async def test_submission_bundle_status_updates_reflected_async(
         assert test_bundle.submission_status.status == "VALIDATED"
         assert test_bundle.submission_status.submission_annotations is not None
         assert "test_score" in test_bundle.submission_status.submission_annotations
-        assert test_bundle.submission_status.submission_annotations["test_score"] == [95.5]
+        assert test_bundle.submission_status.submission_annotations["test_score"] == [
+            95.5
+        ]
 
         # CLEANUP: Reset the status back to original
         submission_status.status = original_status

tests/integration/synapseclient/models/async/test_submission_status_async.py

@@ -221,7 +221,9 @@ async def test_store_submission_status_with_status_change(
 
         # WHEN I update the status
         test_submission_status.status = "VALIDATED"
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN the submission status should be updated
         assert updated_status.id == test_submission_status.id
@@ -239,7 +241,9 @@ async def test_store_submission_status_with_submission_annotations(
             "score": 85.5,
             "feedback": "Good work!",
         }
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN the submission annotations should be saved
         assert updated_status.submission_annotations is not None
@@ -256,7 +260,9 @@ async def test_store_submission_status_with_legacy_annotations(
             "internal_score": 92.3,
             "reviewer_notes": "Excellent submission",
         }
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
         assert updated_status.annotations is not None
 
         converted_annotations = from_submission_status_annotations(
@@ -281,7 +287,9 @@ async def test_store_submission_status_with_combined_annotations(
             "internal_review": True,
             "notes": "Needs minor improvements",
         }
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN both types of annotations should be saved
         assert updated_status.submission_annotations is not None
@@ -307,7 +315,9 @@ async def test_store_submission_status_with_private_annotations_false(
         test_submission_status.private_status_annotations = False
 
         # WHEN I store the submission status
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN they should be properly stored
         assert updated_status.annotations is not None
@@ -340,7 +350,9 @@ async def test_store_submission_status_with_private_annotations_true(
         )
 
         # WHEN I store the submission status
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN they should be properly stored
         assert updated_status.annotations is not None
@@ -395,7 +407,9 @@ async def test_store_submission_status_change_tracking(
         assert test_submission_status.has_changed
 
         # WHEN I store the changes
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
 
         # THEN has_changed should be False again
         assert not updated_status.has_changed
@@ -431,7 +445,9 @@ async def test_has_changed_property_edge_cases(
         assert test_submission_status.has_changed
 
         # WHEN I store and get a fresh copy
-        updated_status = await test_submission_status.store_async(synapse_client=self.syn)
+        updated_status = await test_submission_status.store_async(
+            synapse_client=self.syn
+        )
         fresh_status = await SubmissionStatus(id=updated_status.id).get_async(
             synapse_client=self.syn
         )
@@ -510,7 +526,7 @@ async def test_files(
             finally:
                 # Clean up the temporary file
                 os.unlink(temp_file_path)
-                
+
         return files
 
     @pytest.fixture(scope="function")
@@ -611,7 +627,9 @@ async def test_batch_update_submission_statuses(
         # GIVEN multiple submission statuses
         statuses = []
         for submission in test_submissions:
-            status = await SubmissionStatus(id=submission.id).get_async(synapse_client=self.syn)
+            status = await SubmissionStatus(id=submission.id).get_async(
+                synapse_client=self.syn
+            )
             # Update each status
             status.status = "VALIDATED"
             status.submission_annotations = {
@@ -717,33 +735,35 @@ async def test_submission(
         schedule_for_cleanup(created_submission.id)
         return created_submission
 
-    async def test_submission_cancellation_workflow(
-        self, test_submission: Submission
-    ):
+    async def test_submission_cancellation_workflow(self, test_submission: Submission):
         """Test the complete submission cancellation workflow async."""
         # GIVEN a submission that exists
         submission_id = test_submission.id
-        
+
         # WHEN I get the initial submission status
-        initial_status = await SubmissionStatus(id=submission_id).get_async(synapse_client=self.syn)
-        
+        initial_status = await SubmissionStatus(id=submission_id).get_async(
+            synapse_client=self.syn
+        )
+
         # THEN initially it should not be cancellable or cancelled
         assert initial_status.can_cancel is False
         assert initial_status.cancel_requested is False
-        
+
         # WHEN I update the submission status to allow cancellation
         initial_status.can_cancel = True
         updated_status = await initial_status.store_async(synapse_client=self.syn)
-        
+
         # THEN the submission should be marked as cancellable
         assert updated_status.can_cancel is True
         assert updated_status.cancel_requested is False
-        
+
         # WHEN I cancel the submission
         await test_submission.cancel_async()
-        
+
         # THEN I should be able to retrieve the updated status showing cancellation was requested
-        final_status = await SubmissionStatus(id=submission_id).get_async(synapse_client=self.syn)
+        final_status = await SubmissionStatus(id=submission_id).get_async(
+            synapse_client=self.syn
+        )
         assert final_status.can_cancel is True
         assert final_status.cancel_requested is True
 

tests/integration/synapseclient/models/synchronous/test_submission_bundle.py

@@ -7,7 +7,14 @@
 
 from synapseclient import Synapse
 from synapseclient.core.exceptions import SynapseHTTPError
-from synapseclient.models import Evaluation, File, Project, Submission, SubmissionBundle, SubmissionStatus
+from synapseclient.models import (
+    Evaluation,
+    File,
+    Project,
+    Submission,
+    SubmissionBundle,
+    SubmissionStatus,
+)
 
 
 class TestSubmissionBundleRetrieval:
@@ -22,9 +29,7 @@ def init(self, syn: Synapse, schedule_for_cleanup: Callable[..., None]) -> None:
     async def test_project(
         self, syn: Synapse, schedule_for_cleanup: Callable[..., None]
     ) -> Project:
-        project = Project(name=f"test_project_{uuid.uuid4()}").store(
-            synapse_client=syn
-        )
+        project = Project(name=f"test_project_{uuid.uuid4()}").store(synapse_client=syn)
         schedule_for_cleanup(project.id)
         return project
 
@@ -192,9 +197,15 @@ async def test_get_evaluation_submission_bundles_with_pagination(
 
         # AND the bundle IDs should not overlap if we have enough submissions
         if len(bundles_page1) == 2 and len(bundles_page2) > 0:
-            page1_ids = {bundle.submission.id for bundle in bundles_page1 if bundle.submission}
-            page2_ids = {bundle.submission.id for bundle in bundles_page2 if bundle.submission}
-            assert page1_ids.isdisjoint(page2_ids), "Pages should not have overlapping submissions"
+            page1_ids = {
+                bundle.submission.id for bundle in bundles_page1 if bundle.submission
+            }
+            page2_ids = {
+                bundle.submission.id for bundle in bundles_page2 if bundle.submission
+            }
+            assert page1_ids.isdisjoint(
+                page2_ids
+            ), "Pages should not have overlapping submissions"
 
     async def test_get_evaluation_submission_bundles_invalid_evaluation(self):
         """Test getting submission bundles for invalid evaluation ID."""
@@ -267,9 +278,15 @@ async def test_get_user_submission_bundles_with_pagination(
 
         # AND the bundle IDs should not overlap if we have enough submissions
         if len(bundles_page1) == 2 and len(bundles_page2) > 0:
-            page1_ids = {bundle.submission.id for bundle in bundles_page1 if bundle.submission}
-            page2_ids = {bundle.submission.id for bundle in bundles_page2 if bundle.submission}
-            assert page1_ids.isdisjoint(page2_ids), "Pages should not have overlapping submissions"
+            page1_ids = {
+                bundle.submission.id for bundle in bundles_page1 if bundle.submission
+            }
+            page2_ids = {
+                bundle.submission.id for bundle in bundles_page2 if bundle.submission
+            }
+            assert page1_ids.isdisjoint(
+                page2_ids
+            ), "Pages should not have overlapping submissions"
 
 
 class TestSubmissionBundleDataIntegrity:
@@ -284,9 +301,7 @@ def init(self, syn: Synapse, schedule_for_cleanup: Callable[..., None]) -> None:
     async def test_project(
         self, syn: Synapse, schedule_for_cleanup: Callable[..., None]
     ) -> Project:
-        project = Project(name=f"test_project_{uuid.uuid4()}").store(
-            synapse_client=syn
-        )
+        project = Project(name=f"test_project_{uuid.uuid4()}").store(synapse_client=syn)
         schedule_for_cleanup(project.id)
         return project
 
@@ -410,7 +425,9 @@ async def test_submission_bundle_status_updates_reflected(
         assert test_bundle.submission_status.status == "VALIDATED"
         assert test_bundle.submission_status.submission_annotations is not None
         assert "test_score" in test_bundle.submission_status.submission_annotations
-        assert test_bundle.submission_status.submission_annotations["test_score"] == [95.5]
+        assert test_bundle.submission_status.submission_annotations["test_score"] == [
+            95.5
+        ]
 
         # CLEANUP: Reset the status back to original
         submission_status.status = original_status
@@ -454,9 +471,7 @@ def init(self, syn: Synapse, schedule_for_cleanup: Callable[..., None]) -> None:
     async def test_project(
         self, syn: Synapse, schedule_for_cleanup: Callable[..., None]
     ) -> Project:
-        project = Project(name=f"test_project_{uuid.uuid4()}").store(
-            synapse_client=syn
-        )
+        project = Project(name=f"test_project_{uuid.uuid4()}").store(synapse_client=syn)
         schedule_for_cleanup(project.id)
         return project
 

tests/integration/synapseclient/models/synchronous/test_submission_status.py

@@ -713,31 +713,29 @@ async def test_submission(
         schedule_for_cleanup(created_submission.id)
         return created_submission
 
-    async def test_submission_cancellation_workflow(
-        self, test_submission: Submission
-    ):
+    async def test_submission_cancellation_workflow(self, test_submission: Submission):
         """Test the complete submission cancellation workflow."""
         # GIVEN a submission that exists
         submission_id = test_submission.id
-        
+
         # WHEN I get the initial submission status
         initial_status = SubmissionStatus(id=submission_id).get(synapse_client=self.syn)
-        
+
         # THEN initially it should not be cancellable or cancelled
         assert initial_status.can_cancel is False
         assert initial_status.cancel_requested is False
-        
+
         # WHEN I update the submission status to allow cancellation
         initial_status.can_cancel = True
         updated_status = initial_status.store(synapse_client=self.syn)
-        
+
         # THEN the submission should be marked as cancellable
         assert updated_status.can_cancel is True
         assert updated_status.cancel_requested is False
-        
+
         # WHEN I cancel the submission
         test_submission.cancel()
-        
+
         # THEN I should be able to retrieve the updated status showing cancellation was requested
         final_status = SubmissionStatus(id=submission_id).get(synapse_client=self.syn)
         assert final_status.can_cancel is True