[SYNPY-1714] Fix Issues with Failing Tests (#1287)

* always log warning

* check assert called with

* patch object on class instance

* Revert "always log warning"

This reverts commit ae63c81.

* update patch target

* re-add erroneously removed line

Author: SageGJ

tests/unit/synapseclient/unit_test_client.py

@@ -1172,7 +1172,7 @@ def init_syn(self, syn: Synapse) -> None:
         self.syn.credentials = SynapseAuthTokenCredentials(token="abc", username="def")
 
     def test_check_entity_restrictions_no_unmet_restriction(self) -> None:
-        with patch("logging.Logger.warning") as mocked_warn:
+        with patch.object(self.syn.logger, "warning") as mocked_warn:
             bundle = {
                 "entity": {
                     "id": "syn123",
@@ -1189,7 +1189,7 @@ def test_check_entity_restrictions_no_unmet_restriction(self) -> None:
     def test_check_entity_restrictions_unmet_restriction_entity_file_with_download_file_is_true(
         self,
     ) -> None:
-        with patch("logging.Logger.warning") as mocked_warn:
+        with patch.object(self.syn.logger, "warning") as mocked_warn:
             bundle = {
                 "entity": {
                     "id": "syn123",