From 1a81a271019451ae7b92c6f20a00636935ab9ddb Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 2 Nov 2025 01:27:27 +0000 Subject: [PATCH 1/2] Initial plan From 99bbcee057097bb9ac3714442b868d31ab7bad20 Mon Sep 17 00:00:00 2001 From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com> Date: Sun, 2 Nov 2025 01:30:33 +0000 Subject: [PATCH 2/2] refactor: check hasSettingsApi once outside forEachPlayer loop for better performance Co-authored-by: TheBjoRedCraft <143264463+TheBjoRedCraft@users.noreply.github.com> --- .../dev/slne/surf/essentials/listener/SpecialItemListener.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/main/kotlin/dev/slne/surf/essentials/listener/SpecialItemListener.kt b/src/main/kotlin/dev/slne/surf/essentials/listener/SpecialItemListener.kt index 408aadf..64381fd 100644 --- a/src/main/kotlin/dev/slne/surf/essentials/listener/SpecialItemListener.kt +++ b/src/main/kotlin/dev/slne/surf/essentials/listener/SpecialItemListener.kt @@ -60,6 +60,8 @@ object SpecialItemListener : Listener { it.lore(lore) } + val hasSettingsApi = plugin.hasSettingsApi() + forEachPlayer { it.sendText { appendPrefix() @@ -74,7 +76,7 @@ object SpecialItemListener : Listener { } plugin.launch { - if (plugin.hasSettingsApi()) { + if (hasSettingsApi) { if (settingsService.hasSoundsEnabled(it.uniqueId)) { it.playSound(sound { type(Sound.ENTITY_ENDER_DRAGON_GROWL)