hte: tegra: Fix missing error code in tegra_hte_test_probe()

harshimogalapalli · pateldipen1984-nv · commit b7c3ca3553d1 · 2023-10-27T14:07:15.000-07:00
The value of 'ret' is zero when of_hte_req_count() fails to get number of entitties to timestamp. And returning success(zero) on this failure path is incorrect. Fixes: 9a75a7c ("hte: Add Tegra HTE test driver") Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Reviewed-by: Dipen Patel <dipenp@nvidia.com> Signed-off-by: Dipen Patel <dipenp@nvidia.com>
diff --git a/drivers/hte/hte-tegra194-test.c b/drivers/hte/hte-tegra194-test.c
@@ -153,8 +153,10 @@ static int tegra_hte_test_probe(struct platform_device *pdev)
 	}
 
 	cnt = of_hte_req_count(hte.pdev);
-	if (cnt < 0)
+	if (cnt < 0) {
+		ret = cnt;
 		goto free_irq;
+	}
 
 	dev_info(&pdev->dev, "Total requested lines:%d\n", cnt);
 

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,10 @@ static int tegra_hte_test_probe(struct platform_device *pdev)`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`cnt = of_hte_req_count(hte.pdev);`
`156`		`- if (cnt < 0)`
	`156`	`+ if (cnt < 0) {`
	`157`	`+ ret = cnt;`
`157`	`158`	`goto free_irq;`
	`159`	`+ }`
`158`	`160`
`159`	`161`	`dev_info(&pdev->dev, "Total requested lines:%d\n", cnt);`
`160`	`162`