location assignment: compiletest failing with larger than Vec4 structs due to overlapping locations

Author: Firestar99

tests/compiletests/ui/spirv-attr/location_assignment.rs

@@ -0,0 +1,31 @@
+// build-pass
+// compile-flags: -C llvm-args=--disassemble
+// normalize-stderr-test "OpSource .*\n" -> ""
+// normalize-stderr-test "OpLine .*\n" -> ""
+// normalize-stderr-test "%\d+ = OpString .*\n" -> ""
+// normalize-stderr-test "; .*\n" -> ""
+// normalize-stderr-test "OpCapability VulkanMemoryModel\n" -> ""
+// normalize-stderr-test "OpMemoryModel Logical Vulkan" -> "OpMemoryModel Logical Simple"
+// ignore-spv1.0
+// ignore-spv1.1
+// ignore-spv1.2
+// ignore-spv1.3
+// ignore-vulkan1.0
+// ignore-vulkan1.1
+
+use spirv_std::glam::*;
+use spirv_std::{Image, spirv};
+
+#[derive(Copy, Clone, Default)]
+pub struct LargerThanVec4 {
+    a: Vec4,
+    b: Vec2,
+}
+
+#[spirv(vertex)]
+pub fn main(out1: &mut LargerThanVec4, out2: &mut Vec2, out3: &mut Mat4, out4: &mut f32) {
+    *out1 = Default::default();
+    *out2 = Default::default();
+    *out3 = Default::default();
+    *out4 = Default::default();
+}

tests/compiletests/ui/spirv-attr/location_assignment.stderr

@@ -0,0 +1,78 @@
+OpCapability Shader
+OpMemoryModel Logical Simple
+OpEntryPoint Vertex %1 "main" %2 %3 %4 %5
+OpName %7 "LargerThanVec4"
+OpMemberName %7 0 "a"
+OpMemberName %7 1 "b"
+OpName %8 "spirv_std::glam::Mat4"
+OpMemberName %8 0 "x_axis"
+OpMemberName %8 1 "y_axis"
+OpMemberName %8 2 "z_axis"
+OpMemberName %8 3 "w_axis"
+OpName %9 "LargerThanVec4"
+OpMemberName %9 0 "a"
+OpMemberName %9 1 "b"
+OpName %2 "out1"
+OpName %3 "out2"
+OpName %4 "out3"
+OpName %5 "out4"
+OpMemberDecorate %9 0 Offset 0
+OpMemberDecorate %9 1 Offset 16
+OpDecorate %2 Location 0
+OpDecorate %3 Location 1
+OpDecorate %4 Location 2
+OpDecorate %5 Location 3
+%10 = OpTypeFloat 32
+%11 = OpTypeVector %10 4
+%12 = OpTypeVector %10 2
+%7 = OpTypeStruct %11 %12
+%13 = OpTypePointer Output %7
+%14 = OpTypePointer Output %12
+%8 = OpTypeStruct %11 %11 %11 %11
+%15 = OpTypePointer Output %8
+%16 = OpTypePointer Output %10
+%17 = OpTypeVoid
+%18 = OpTypeFunction %17
+%9 = OpTypeStruct %11 %12
+%19 = OpConstant  %10  0
+%20 = OpConstantComposite  %11  %19 %19 %19 %19
+%21 = OpUndef  %9
+%2 = OpVariable  %13  Output
+%3 = OpVariable  %14  Output
+%22 = OpTypeInt 32 0
+%23 = OpConstant  %22  0
+%24 = OpConstant  %22  1
+%4 = OpVariable  %15  Output
+%25 = OpConstant  %10  1
+%26 = OpConstantComposite  %11  %25 %19 %19 %19
+%27 = OpConstantComposite  %11  %19 %25 %19 %19
+%28 = OpConstantComposite  %11  %19 %19 %25 %19
+%29 = OpConstantComposite  %11  %19 %19 %19 %25
+%30 = OpConstantComposite  %8  %26 %27 %28 %29
+%5 = OpVariable  %16  Output
+%1 = OpFunction  %17  None %18
+%31 = OpLabel
+%32 = OpCompositeInsert  %9  %20 %21 0
+%33 = OpCompositeInsert  %9  %19 %32 1 0
+%34 = OpCompositeInsert  %9  %19 %33 1 1
+%35 = OpCompositeExtract  %11  %34 0
+%36 = OpCompositeExtract  %12  %34 1
+%37 = OpCompositeConstruct  %7  %35 %36
+OpStore %2 %37
+%38 = OpInBoundsAccessChain  %16  %3 %23
+OpStore %38 %19
+%39 = OpInBoundsAccessChain  %16  %3 %24
+OpStore %39 %19
+OpStore %4 %30
+OpStore %5 %19
+OpNoLine
+OpReturn
+OpFunctionEnd
+error: error:0:0 - [VUID-StandaloneSpirv-OpEntryPoint-08722] Entry-point has conflicting output location assignment at location 1, component 0
+         OpEntryPoint Vertex %1 "main" %out1 %out2 %out3 %out4
+   |
+   = note: spirv-val failed
+   = note: module `$TEST_BUILD_DIR/spirv-attr/location_assignment.vulkan1.2`
+
+error: aborting due to 1 previous error
+