Skip to content

Commit 9bc2a74

Browse files
nnethercoteLegNeato
authored andcommitted
Disable compilation of crates that use OptiX.
Because they don't work without OptiX, which is less important than CUDA and a pain to install. This means we don't have to manually exclude all these crates in CI, which is nice -- e.g. a vanilla `cargo build` works. Also, on Linux CI we don't need `--exclude "cudnn*"`. (We still need it on Windows CI.)
1 parent 4ea27fb commit 9bc2a74

File tree

4 files changed

+96
-1949
lines changed

4 files changed

+96
-1949
lines changed

.github/workflows/ci_linux.yml

Lines changed: 2 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -148,24 +148,14 @@ jobs:
148148
- name: Build workspace
149149
run: |
150150
docker exec "$CONTAINER_NAME" bash -lc 'set -euo pipefail
151-
cargo build --workspace \
152-
--exclude "optix*" \
153-
--exclude "path-tracer" \
154-
--exclude "denoiser" \
155-
--exclude "ex0*" \
156-
--exclude "cudnn*"
151+
cargo build
157152
'
158153
159154
- name: Clippy
160155
run: |
161156
docker exec "$CONTAINER_NAME" bash -lc 'set -euo pipefail
162157
export RUSTFLAGS=-Dwarnings
163-
cargo clippy --workspace \
164-
--exclude "optix*" \
165-
--exclude "path-tracer" \
166-
--exclude "denoiser" \
167-
--exclude "ex0*" \
168-
--exclude "cudnn*"
158+
cargo clippy
169159
'
170160
171161
# Very limited testing because we can only run tests that don't rely on having a CUDA GPU.
@@ -185,11 +175,6 @@ jobs:
185175
docker exec "$CONTAINER_NAME" bash -lc 'set -euo pipefail
186176
export RUSTDOCFLAGS=-Dwarnings
187177
cargo doc --workspace --all-features --document-private-items --no-deps \
188-
--exclude "optix*" \
189-
--exclude "path-tracer" \
190-
--exclude "denoiser" \
191-
--exclude "ex0*" \
192-
--exclude "cudnn*" \
193178
--exclude "cust_raw"
194179
'
195180

.github/workflows/ci_windows.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,13 +88,13 @@ jobs:
8888
- name: Build all bindings
8989
run: cargo build --all-features -p cust_raw
9090

91-
- name: Build
92-
run: cargo build --workspace --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*" --exclude "i128*"
91+
- name: Build workspace
92+
run: cargo build --workspace --exclude "cudnn*" --exclude "gemm*" --exclude "i128*" --exclude "sha2*" --exclude "vecadd*"
9393

9494
- name: Clippy
9595
env:
9696
RUSTFLAGS: -Dwarnings
97-
run: cargo clippy --workspace --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*" --exclude "i128*"
97+
run: cargo clippy --workspace --exclude "cudnn*" --exclude "gemm*" --exclude "i128*" --exclude "sha2*" --exclude "vecadd*"
9898

9999
# Very limited testing because we can only run tests that don't rely on having a CUDA GPU.
100100
- name: Test
@@ -103,7 +103,8 @@ jobs:
103103
- name: Check documentation
104104
env:
105105
RUSTDOCFLAGS: -Dwarnings
106-
run: cargo doc --workspace --all-features --document-private-items --no-deps --exclude "optix*" --exclude "path-tracer" --exclude "denoiser" --exclude "vecadd*" --exclude "gemm*" --exclude "ex*" --exclude "cudnn*" --exclude "sha2*" --exclude "i128*" --exclude "cust_raw"
107-
# Disabled due to dll issues, someone with Windows knowledge needed
106+
run: cargo doc --workspace --all-features --document-private-items --no-deps --exclude "cudnn*" --exclude "cust_raw" --exclude "gemm*" --exclude "i128*" --exclude "sha2*" --exclude "vecadd*"
107+
108+
# Disabled due to dll issues, someone with Windows knowledge needed
108109
# - name: Compiletest
109110
# run: cargo run -p compiletests --release --no-default-features -- --target-arch compute_61,compute_75,compute_90

0 commit comments

Comments
 (0)