Panic when nvcc can't be found by which (#151)

std::process::Command.output() doesn't return error on non-zero exit, only
when command.inner() fails.

If `which nvcc` can't find `nvcc` it returns like (ExitStatus(-1), "", "")
and causes a panic in the return of the function.

Instead, panic on non-zero return with an informational diagnostic message.

Author: superimposition

crates/find_cuda_helper/src/lib.rs

@@ -157,10 +157,13 @@ fn detect_cuda_root_via_which_nvcc() -> PathBuf {
     let output = Command::new("which")
         .arg("nvcc")
         .output()
-        .expect("Command `which` must be available on *nix like systems.")
-        .stdout;
+        .expect("Command `which` must be available on *nix like systems.");
 
-    let path: PathBuf = String::from_utf8(output)
+    if !output.status.success() {
+        panic!("Couldn't find nvcc - `which nvcc` returned non-zero");
+    }
+
+    let path: PathBuf = String::from_utf8(output.stdout)
         .expect("Result must be valid UTF-8")
         .trim()
         .to_string()