Addon throws excepting

[DaVukovic]

Hi.

I'm a TeamKodi member and obviously your Add-on (which is in our repo since Kodi Jarvis) throws an error:

2021-11-06 06:34:56.805 T:1488    ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'AttributeError'>
                                                   Error Contents: module 'xbmc' has no attribute 'abortRequested'
                                                   Traceback (most recent call last):
                                                     File "/storage/.kodi/addons/script.user.rating/service.py", line 44, in <module>
                                                       while(not xbmc.abortRequested):
                                                   AttributeError: module 'xbmc' has no attribute 'abortRequested'
                                                   -->End of Python script error report<--
                                                   
2021-11-06 06:34:57.005 T:1488     INFO <general>: Python interpreter stopped

I'm not a python dev myself, but monitor went into core and therefor it has to be used like

xbmc.Monitor().abortRequestet

or maybe even better:

mon = xbmc.Monitor()
while not mon.abortRequestet

Please let me know if you plan to update the addon. If not, would it be ok for you if someone forks your work and pushes an update to the Kodi repo?

Cheers and nice weekend.
DaVu

[b-jesch]

As a Monitor class is already built from xbmc.Monitor():

script.user.rating/service.py

Line 13 in 81c9324

class Monitor(xbmc.Monitor):

and instanced:

script.user.rating/service.py

Line 41 in 81c9324

monitor = Monitor()

it is sufficient to replace the code in line 43 simply with while not monitor.abortRequested(): That should fix the bug.

[DaVukovic]

I would like to let you know that I forked your work.

If you would like to investigate and update your add-on, please feel free to contact me and I submit my changes to your branch.

You are the initial developer and don't want to sound that I steal your work. But I would like to have a working addon at the Kodi repository.