Avoid calling CDOTC, ZDOTC, CDOTU, ZDOTU

These BLAS functions return a complex number and this may produce ABI
conflict if using a BLAS compiled with a Fortran compiler with different
calling convention (e.g. macOS Accelerate framework). Use an equivalent
subroutine instead.

Author: joseeroman

PBLAS/SRC/PTZBLAS/cvvdotc.f

@@ -54,13 +54,16 @@ SUBROUTINE CVVDOTC( N, DOT, X, INCX, Y, INCY )
 *
 *  =====================================================================
 *
-*     .. External Functions ..
-      COMPLEX            CDOTC
-      EXTERNAL           CDOTC
+*     .. Local Scalars ..
+      COMPLEX            DOTC
+*     ..
+*     .. External Subroutines ..
+      EXTERNAL           CCDOTC
 *     ..
 *     .. Executable Statements ..
 *
-      DOT = DOT + CDOTC( N, X, INCX, Y, INCY )
+      CALL CCDOTC( N, DOTC, X, INCX, Y, INCY )
+      DOT = DOT + DOTC
 *
       RETURN
 *

PBLAS/SRC/PTZBLAS/cvvdotu.f

@@ -54,13 +54,16 @@ SUBROUTINE CVVDOTU( N, DOT, X, INCX, Y, INCY )
 *
 *  =====================================================================
 *
-*     .. External Functions ..
-      COMPLEX            CDOTU
-      EXTERNAL           CDOTU
+*     .. Local Scalars ..
+      COMPLEX            DOTU
+*     ..
+*     .. External Subroutines ..
+      EXTERNAL           CCDOTU
 *     ..
 *     .. Executable Statements ..
 *
-      DOT = DOT + CDOTU( N, X, INCX, Y, INCY )
+      CALL CCDOTU( N, DOTU, X, INCX, Y, INCY )
+      DOT = DOT + DOTU
 *
       RETURN
 *

PBLAS/SRC/PTZBLAS/zvvdotc.f

@@ -54,13 +54,16 @@ SUBROUTINE ZVVDOTC( N, DOT, X, INCX, Y, INCY )
 *
 *  =====================================================================
 *
-*     .. External Functions ..
-      COMPLEX*16         ZDOTC
-      EXTERNAL           ZDOTC
+*     .. Local Scalars ..
+      COMPLEX*16         DOTC
+*     ..
+*     .. External Subroutines ..
+      EXTERNAL           ZZDOTC
 *     ..
 *     .. Executable Statements ..
 *
-      DOT = DOT + ZDOTC( N, X, INCX, Y, INCY )
+      CALL ZZDOTC( N, DOTC, X, INCX, Y, INCY )
+      DOT = DOT + DOTC
 *
       RETURN
 *

PBLAS/SRC/PTZBLAS/zvvdotu.f

@@ -54,13 +54,16 @@ SUBROUTINE ZVVDOTU( N, DOT, X, INCX, Y, INCY )
 *
 *  =====================================================================
 *
-*     .. External Functions ..
-      COMPLEX*16         ZDOTU
-      EXTERNAL           ZDOTU
+*     .. Local Scalars ..
+      COMPLEX*16         DOTU
+*     ..
+*     .. External Subroutines ..
+      EXTERNAL           ZZDOTU
 *     ..
 *     .. Executable Statements ..
 *
-      DOT = DOT + ZDOTU( N, X, INCX, Y, INCY )
+      CALL ZZDOTU( N, DOTU, X, INCX, Y, INCY )
+      DOT = DOT + DOTU
 *
       RETURN
 *

SRC/pcdttrf.f

@@ -376,22 +376,22 @@ SUBROUTINE PCDTTRF( N, DL, D, DU, JA, DESCA, AF, LAF, WORK, LWORK,
      $                   NB, NP, NPCOL, NPROW, NP_SAVE, ODD_SIZE,
      $                   PART_OFFSET, PART_SIZE, RETURN_CODE, STORE_N_A,
      $                   TEMP, WORK_SIZE_MIN, WORK_U
+      COMPLEX            DOTC
 *     ..
 *     .. Local Arrays ..
       INTEGER            DESCA_1XP( 7 ), PARAM_CHECK( 7, 3 )
 *     ..
 *     .. External Subroutines ..
       EXTERNAL           BLACS_GET, BLACS_GRIDEXIT, BLACS_GRIDINFO,
-     $                   CAXPY, CGEMM, CGERV2D, CGESD2D, CLAMOV,
+     $                   CAXPY, CCDOTC, CGEMM, CGERV2D, CGESD2D, CLAMOV,
      $                   CLATCPY, CPBTRF, CPOTRF, CSYRK, CTBTRS, CTRMM,
      $                   CTRRV2D, CTRSD2D, CTRSM, CTRTRS, DESC_CONVERT,
      $                   GLOBCHK, PXERBLA, RESHAPE
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
       INTEGER            NUMROC
-      COMPLEX            CDOTC
-      EXTERNAL           CDOTC, LSAME, NUMROC
+      EXTERNAL           LSAME, NUMROC
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ICHAR, MIN, MOD
@@ -741,8 +741,8 @@ SUBROUTINE PCDTTRF( N, DL, D, DU, JA, DESCA, AF, LAF, WORK, LWORK,
 *
 *         Calculate the update block for previous proc, E_i = GL_i{GU_i}
 *
-          AF( ODD_SIZE+3 ) = -CONE *
-     $        CDOTC( ODD_SIZE, AF( 1 ), 1, AF( WORK_U+1 ), 1 )
+          CALL CCDOTC( ODD_SIZE, DOTC, AF( 1 ), 1, AF( WORK_U+1 ), 1 )
+          AF( ODD_SIZE+3 ) = -CONE * DOTC
 *
 *
 *         Initiate send of E_i to previous processor to overlap

SRC/pchetd2.f

@@ -228,17 +228,16 @@ SUBROUTINE PCHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
       INTEGER            IACOL, IAROW, ICOFFA, ICTXT, II, IK, IROFFA, J,
      $                   JJ, JK, JN, LDA, LWMIN, MYCOL, MYROW, NPCOL,
      $                   NPROW
-      COMPLEX            ALPHA, TAUI
+      COMPLEX            ALPHA, TAUI, DOTC
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           BLACS_ABORT, BLACS_GRIDINFO, CAXPY, CGEBR2D,
-     $                   CGEBS2D, CHK1MAT, CHEMV,
+      EXTERNAL           BLACS_ABORT, BLACS_GRIDINFO, CAXPY, CCDOTC,
+     $                   CGEBR2D, CGEBS2D, CHK1MAT, CHEMV,
      $                   CHER2, CLARFG, INFOG2L, PXERBLA
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
-      COMPLEX            CDOTC
-      EXTERNAL           LSAME, CDOTC
+      EXTERNAL           LSAME
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          CMPLX, REAL
@@ -333,8 +332,9 @@ SUBROUTINE PCHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
 *
 *                    Compute  w := x - 1/2 * tau * (x'*v) * v
 *
-                     ALPHA = -HALF*TAUI*CDOTC( J, TAU( JJ ), 1,
-     $                                         A( II+JK*LDA ), 1 )
+                     CALL CCDOTC( J, DOTC, TAU( JJ ), 1, A( II+JK*LDA ),
+     $                           1 )
+                     ALPHA = -HALF*TAUI*DOTC
                      CALL CAXPY( J, ALPHA, A( II+JK*LDA ), 1,
      $                           TAU( JJ ), 1 )
 *
@@ -413,8 +413,9 @@ SUBROUTINE PCHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
 *
 *                    Compute  w := x - 1/2 * tau * (x'*v) * v
 *
-                     ALPHA = -HALF*TAUI*CDOTC( N-J, TAU( JK ), 1,
-     $                        A( IK+1+(JK-1)*LDA ), 1 )
+                     CALL CCDOTC( N-J, DOTC, TAU( JK ), 1,
+     $                            A( IK+1+(JK-1)*LDA ), 1 )
+                     ALPHA = -HALF*TAUI*DOTC
                      CALL CAXPY( N-J, ALPHA, A( IK+1+(JK-1)*LDA ),
      $                           1, TAU( JK ), 1 )
 *

SRC/pclauu2.f

@@ -131,15 +131,15 @@ SUBROUTINE PCLAUU2( UPLO, N, A, IA, JA, DESCA )
       INTEGER            IACOL, IAROW, ICURR, IDIAG, IIA, IOFFA, JJA,
      $                   LDA, MYCOL, MYROW, NA, NPCOL, NPROW
       REAL               AII
+      COMPLEX            DOTC
 *     ..
 *     .. External Subroutines ..
-      EXTERNAL           BLACS_GRIDINFO, CGEMV, CLACGV,
+      EXTERNAL           BLACS_GRIDINFO, CCDOTC, CGEMV, CLACGV,
      $                   CSSCAL, INFOG2L
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
-      COMPLEX            CDOTC
-      EXTERNAL           CDOTC, LSAME
+      EXTERNAL           LSAME
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          CMPLX, REAL
@@ -170,8 +170,8 @@ SUBROUTINE PCLAUU2( UPLO, N, A, IA, JA, DESCA )
             DO 10 NA = N-1, 1, -1
                AII = A( IDIAG )
                ICURR = IDIAG + LDA
-               A( IDIAG ) = AII*AII + REAL( CDOTC( NA, A( ICURR ), LDA,
-     $                                           A( ICURR ), LDA ) )
+               CALL CCDOTC( NA, DOTC, A( ICURR ), LDA, A( ICURR ), LDA )
+               A( IDIAG ) = AII*AII + REAL( DOTC )
                CALL CLACGV( NA, A( ICURR ), LDA )
                CALL CGEMV( 'No transpose', N-NA-1, NA, ONE,
      $                     A( IOFFA+LDA ), LDA, A( ICURR ), LDA,

SRC/pzdttrf.f

@@ -376,6 +376,7 @@ SUBROUTINE PZDTTRF( N, DL, D, DU, JA, DESCA, AF, LAF, WORK, LWORK,
      $                   NB, NP, NPCOL, NPROW, NP_SAVE, ODD_SIZE,
      $                   PART_OFFSET, PART_SIZE, RETURN_CODE, STORE_N_A,
      $                   TEMP, WORK_SIZE_MIN, WORK_U
+      COMPLEX*16         DOTC
 *     ..
 *     .. Local Arrays ..
       INTEGER            DESCA_1XP( 7 ), PARAM_CHECK( 7, 3 )
@@ -385,13 +386,12 @@ SUBROUTINE PZDTTRF( N, DL, D, DU, JA, DESCA, AF, LAF, WORK, LWORK,
      $                   DESC_CONVERT, GLOBCHK, PXERBLA, RESHAPE, ZAXPY,
      $                   ZGEMM, ZGERV2D, ZGESD2D, ZLAMOV, ZLATCPY,
      $                   ZPBTRF, ZPOTRF, ZSYRK, ZTBTRS, ZTRMM, ZTRRV2D,
-     $                   ZTRSD2D, ZTRSM, ZTRTRS
+     $                   ZTRSD2D, ZTRSM, ZTRTRS, ZZDOTC
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
       INTEGER            NUMROC
-      COMPLEX*16         ZDOTC
-      EXTERNAL           LSAME, NUMROC, ZDOTC
+      EXTERNAL           LSAME, NUMROC
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          ICHAR, MIN, MOD
@@ -741,8 +741,8 @@ SUBROUTINE PZDTTRF( N, DL, D, DU, JA, DESCA, AF, LAF, WORK, LWORK,
 *
 *         Calculate the update block for previous proc, E_i = GL_i{GU_i}
 *
-          AF( ODD_SIZE+3 ) = -CONE *
-     $        ZDOTC( ODD_SIZE, AF( 1 ), 1, AF( WORK_U+1 ), 1 )
+          CALL ZZDOTC( ODD_SIZE, DOTC, AF( 1 ), 1, AF( WORK_U+1 ), 1 )
+          AF( ODD_SIZE+3 ) = -CONE * DOTC
 *
 *
 *         Initiate send of E_i to previous processor to overlap

SRC/pzhetd2.f

@@ -228,17 +228,16 @@ SUBROUTINE PZHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
       INTEGER            IACOL, IAROW, ICOFFA, ICTXT, II, IK, IROFFA, J,
      $                   JJ, JK, JN, LDA, LWMIN, MYCOL, MYROW, NPCOL,
      $                   NPROW
-      COMPLEX*16         ALPHA, TAUI
+      COMPLEX*16         ALPHA, TAUI, DOTC
 *     ..
 *     .. External Subroutines ..
       EXTERNAL           BLACS_ABORT, BLACS_GRIDINFO, CHK1MAT, INFOG2L,
      $                   PXERBLA, ZAXPY, ZGEBR2D, ZGEBS2D,
-     $                   ZHEMV, ZHER2, ZLARFG
+     $                   ZHEMV, ZHER2, ZLARFG, ZZDOTC
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
-      COMPLEX*16         ZDOTC
-      EXTERNAL           LSAME, ZDOTC
+      EXTERNAL           LSAME
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          DBLE, DCMPLX
@@ -333,8 +332,9 @@ SUBROUTINE PZHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
 *
 *                    Compute  w := x - 1/2 * tau * (x'*v) * v
 *
-                     ALPHA = -HALF*TAUI*ZDOTC( J, TAU( JJ ), 1,
-     $                                         A( II+JK*LDA ), 1 )
+                     CALL ZZDOTC( J, DOTC, TAU( JJ ), 1, A( II+JK*LDA ),
+     $                            1 )
+                     ALPHA = -HALF*TAUI*DOTC
                      CALL ZAXPY( J, ALPHA, A( II+JK*LDA ), 1,
      $                           TAU( JJ ), 1 )
 *
@@ -413,8 +413,9 @@ SUBROUTINE PZHETD2( UPLO, N, A, IA, JA, DESCA, D, E, TAU, WORK,
 *
 *                    Compute  w := x - 1/2 * tau * (x'*v) * v
 *
-                     ALPHA = -HALF*TAUI*ZDOTC( N-J, TAU( JK ), 1,
-     $                        A( IK+1+(JK-1)*LDA ), 1 )
+                     CALL ZZDOTC( N-J, DOTC, TAU( JK ), 1,
+     $                            A( IK+1+(JK-1)*LDA ), 1 )
+                     ALPHA = -HALF*TAUI*DOTC
                      CALL ZAXPY( N-J, ALPHA, A( IK+1+(JK-1)*LDA ),
      $                           1, TAU( JK ), 1 )
 *

SRC/pzlauu2.f

@@ -131,15 +131,15 @@ SUBROUTINE PZLAUU2( UPLO, N, A, IA, JA, DESCA )
       INTEGER            IACOL, IAROW, ICURR, IDIAG, IIA, IOFFA, JJA,
      $                   LDA, MYCOL, MYROW, NA, NPCOL, NPROW
       DOUBLE PRECISION   AII
+      COMPLEX*16         DOTC
 *     ..
 *     .. External Subroutines ..
       EXTERNAL           BLACS_GRIDINFO, INFOG2L, ZDSCAL, ZGEMV,
-     $                   ZLACGV
+     $                   ZLACGV, ZZDOTC
 *     ..
 *     .. External Functions ..
       LOGICAL            LSAME
-      COMPLEX*16         ZDOTC
-      EXTERNAL           LSAME, ZDOTC
+      EXTERNAL           LSAME
 *     ..
 *     .. Intrinsic Functions ..
       INTRINSIC          DCMPLX, DBLE
@@ -170,8 +170,8 @@ SUBROUTINE PZLAUU2( UPLO, N, A, IA, JA, DESCA )
             DO 10 NA = N-1, 1, -1
                AII = A( IDIAG )
                ICURR = IDIAG + LDA
-               A( IDIAG ) = AII*AII + DBLE( ZDOTC( NA, A( ICURR ), LDA,
-     $                                           A( ICURR ), LDA ) )
+               CALL ZZDOTC( NA, DOTC, A( ICURR ), LDA, A( ICURR ), LDA )
+               A( IDIAG ) = AII*AII + DBLE( DOTC )
                CALL ZLACGV( NA, A( ICURR ), LDA )
                CALL ZGEMV( 'No transpose', N-NA-1, NA, ONE,
      $                     A( IOFFA+LDA ), LDA, A( ICURR ), LDA,