Skip to content

Commit f055248

Browse files
committed
Split valgrind in CI to 3
1 parent 3eacedf commit f055248

File tree

2 files changed

+64
-7
lines changed

2 files changed

+64
-7
lines changed

.circleci/config.yml

Lines changed: 63 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,63 @@ jobs:
201201
- run:
202202
name: Test with valgrind
203203
command: |
204-
make -C opt test VALGRIND=1
204+
make -C opt test VALGRIND=1 CLUSTER=0 AOF=0
205+
no_output_timeout: 120m
206+
207+
valgrind-cluster:
208+
docker:
209+
- image: redisfab/rmbuilder:6.0.5-x64-buster
210+
steps:
211+
- checkout
212+
- run:
213+
name: Submodule checkout
214+
command: git submodule update --init --recursive
215+
- restore_cache:
216+
keys:
217+
- build-dependencies-{{ checksum "get_deps.sh" }}
218+
# If no exact match is found will get dependencies from source
219+
- setup-automation
220+
- run:
221+
name: Install dependencies
222+
command: |
223+
./opt/readies/bin/getredis -v 6 --valgrind --force
224+
./get_deps.sh cpu
225+
- run:
226+
name: Build for valgrind with cluster
227+
command: |
228+
make -C opt all VALGRIND=1 SHOW=1
229+
- run:
230+
name: Test with valgrind and cluster
231+
command: |
232+
make -C opt test VALGRIND=1 GEN=0 AOF=0
233+
no_output_timeout: 120m
234+
235+
valgrind-AOF:
236+
docker:
237+
- image: redisfab/rmbuilder:6.0.5-x64-buster
238+
steps:
239+
- checkout
240+
- run:
241+
name: Submodule checkout
242+
command: git submodule update --init --recursive
243+
- restore_cache:
244+
keys:
245+
- build-dependencies-{{ checksum "get_deps.sh" }}
246+
# If no exact match is found will get dependencies from source
247+
- setup-automation
248+
- run:
249+
name: Install dependencies
250+
command: |
251+
./opt/readies/bin/getredis -v 6 --valgrind --force
252+
./get_deps.sh cpu
253+
- run:
254+
name: Build for valgrind with AOF
255+
command: |
256+
make -C opt all VALGRIND=1 SHOW=1
257+
- run:
258+
name: Test with valgrind and AOF
259+
command: |
260+
make -C opt test VALGRIND=1 GEN=0 CLUSTER=0
205261
no_output_timeout: 120m
206262

207263
build-macos:
@@ -408,6 +464,12 @@ workflows:
408464
- valgrind:
409465
<<: *on-any-branch
410466
<<: *after-linter
467+
- valgrind-cluster:
468+
<<: *on-any-branch
469+
<<: *after-linter
470+
- valgrind-AOF:
471+
<<: *on-any-branch
472+
<<: *after-linter
411473
- build-and-test-gpu:
412474
<<: *on-any-branch
413475
<<: *after-linter

tests/flow/tests_dag.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -227,9 +227,7 @@ def test_dagro_common_errors(env):
227227
def test_dagrun_ro_modelrun_scriptrun_resnet(env):
228228
if (not TEST_TF or not TEST_PT):
229229
return
230-
if(VALGRIND):
231-
env.debugPrint("skipping {} since it's hanging CI".format(sys._getframe().f_code.co_name), force=True)
232-
env.skip()
230+
233231
con = env.getConnection()
234232
model_name = 'imagenet_model{{1}}'
235233
script_name = 'imagenet_script{{1}}'
@@ -277,9 +275,6 @@ def test_dagrun_ro_modelrun_scriptrun_resnet(env):
277275
def test_dagrun_modelrun_scriptrun_resnet(env):
278276
if (not TEST_TF or not TEST_PT):
279277
return
280-
if(VALGRIND):
281-
env.debugPrint("skipping {} since it's hanging CI".format(sys._getframe().f_code.co_name), force=True)
282-
env.skip()
283278
con = env.getConnection()
284279
model_name = 'imagenet_model:{{1}}'
285280
script_name = 'imagenet_script:{{1}}'

0 commit comments

Comments
 (0)