Slowlog implementation - cherry pick (#886)

* Slowlog implementation (#883)

* added slowlog timer implementation
and updated redismodule.h file

* added test for slowlog timer implementation

* replaced time_ns() with time()
for python <3.7 compatibility

* splited asserts for better error catching

* instead of assuming last command was DAGEXECUTE,
search for the command in the last 10 commands

* Added a wrapper for skipping test by redis version
improved test_slowlog_time_dag_modelexecute_financialNet_autobatch test

* added a check for version before using
RedisModule_BlockedClientMeasureTime functions
(supported from version 6.2)

* Review fixes:

Added 'patch' argument for skip_if_not_version command.

Added comments in
test_slowlog_time_dag_modelexecute_financialNet_autobatch test.

* Valgring test will run on 6.0 redis,
until additional support will be added

* Slowlog impl fix (#885)

* fix for circleci valgrind-cluster test:
uses 6.2.5-x64-bullseye again

* fix the debug messege:
will display the test-function name now

* update valgrind test to 6.2

Author: GuyAv46

.circleci/config.yml

@@ -176,7 +176,7 @@ commands:
       - run:
           name: Install dependencies
           command: |
-            ./opt/readies/bin/getredis -v 6.0 --valgrind --force
+            ./opt/readies/bin/getredis -v 6.2 --valgrind --force
             ./get_deps.sh cpu
       - run:
           name: Build for valgrind
@@ -359,7 +359,7 @@ jobs:
       - run:
           name: Install dependencies
           command: |
-            ./opt/readies/bin/getredis -v 6.0 --valgrind --force
+            ./opt/readies/bin/getredis -v 6.2 --valgrind --force
             ./get_deps.sh cpu
       - run:
           name: Build for valgrind

src/execution/DAG/dag.c

@@ -210,7 +210,6 @@ void RedisAI_BatchedDagRunSession_ModelRun_Step(RedisAI_RunInfo **batched_rinfo,
     }
 
     RAI_Error err = {0};
-    RAI_Model *model = RAI_ModelRunCtxGetModel((RAI_ModelRunCtx *)ectxs[0]);
     const long long start = ustime();
     int result = RAI_ModelRun((RAI_ModelRunCtx **)ectxs, n_rinfo, &err);
     const long long end = ustime();
@@ -686,6 +685,10 @@ void DAG_ReplyAndUnblock(RedisAI_OnFinishCtx *ctx, void *private_data) {
 
     RedisAI_RunInfo *rinfo = (RedisAI_RunInfo *)ctx;
     if (rinfo->client) {
+        if (RedisModule_GetServerVersion() >=
+            0x060200) { // The following command is supported only from redis 6.2
+            RedisModule_BlockedClientMeasureTimeEnd(rinfo->client);
+        }
         RedisModule_UnblockClient(rinfo->client, rinfo);
     }
 }

src/execution/command_parser.c

@@ -71,5 +71,9 @@ int RedisAI_ExecuteCommand(RedisModuleCtx *ctx, RedisModuleString **argv, int ar
         RedisModule_UnblockClient(rinfo->client, rinfo);
         return REDISMODULE_ERR;
     }
+    if (RedisModule_GetServerVersion() >=
+        0x060200) { // The following command is supported only from redis 6.2
+        RedisModule_BlockedClientMeasureTimeStart(rinfo->client);
+    }
     return REDISMODULE_OK;
 }