revert bindings + flow tests changes (move to another PR)

Author: alonre24

src/VecSim/algorithms/brute_force/brute_force_multi.h

@@ -33,14 +33,14 @@ class BruteForceIndex_Multi : public BruteForceIndex<DataType, DistType> {
             new (this->allocator) vecsim_stl::unique_results_container(cap, this->allocator));
     }
 #ifdef BUILD_TESTS
-    void getDataByLabel(labelType label, std::vector<const char *> &vectors_output) const {
+    void GetDataByLabel(labelType label, std::vector<std::vector<DataType>> &vectors_output) {
 
         auto ids = labelToIdsLookup.find(label);
 
         for (idType id : ids->second) {
-            auto *vec_copy = new DataType[this->dim];
-            memcpy(vec_copy, this->getDataByInternalId(id), this->dim * sizeof(DataType));
-            vectors_output.push_back((const char *)vec_copy);
+            auto vec = std::vector<DataType>(this->dim);
+            memcpy(vec.data(), this->getDataByInternalId(id), this->dim * sizeof(DataType));
+            vectors_output.push_back(vec);
         }
     }
 #endif

src/VecSim/algorithms/brute_force/brute_force_single.h

@@ -32,13 +32,13 @@ class BruteForceIndex_Single : public BruteForceIndex<DataType, DistType> {
 
     inline size_t indexLabelCount() const override { return this->count; }
 #ifdef BUILD_TESTS
-    void getDataByLabel(labelType label, std::vector<const char *> &vectors_output) const {
+    void GetDataByLabel(labelType label, std::vector<std::vector<DataType>> &vectors_output) {
 
         auto id = labelToIdLookup.at(label);
 
-        auto *vec_copy = new DataType[this->dim];
-        memcpy(vec_copy, this->getDataByInternalId(id), this->dim * sizeof(DataType));
-        vectors_output.push_back((const char *)vec_copy);
+        auto vec = std::vector<DataType>(this->dim);
+        memcpy(vec.data(), this->getDataByInternalId(id), this->dim * sizeof(DataType));
+        vectors_output.push_back(vec);
     }
 #endif
 protected:

src/VecSim/algorithms/hnsw/hnsw_multi.h

@@ -42,14 +42,14 @@ class HNSWIndex_Multi : public HNSWIndex<DataType, DistType> {
         : HNSWIndex<DataType, DistType>(input, params, allocator, version),
           label_lookup_(this->max_elements_, allocator) {}
 
-    void getDataByLabel(labelType label, std::vector<const char *> &vectors_output) const {
+    void GetDataByLabel(labelType label, std::vector<std::vector<DataType>> &vectors_output) {
 
         auto ids = label_lookup_.find(label);
 
         for (idType id : ids->second) {
-            auto *vec_copy = new DataType[this->dim];
-            memcpy(vec_copy, this->getDataByInternalId(id), this->data_size_);
-            vectors_output.push_back((const char *)vec_copy);
+            auto vec = std::vector<DataType>(this->dim);
+            memcpy(vec.data(), this->getDataByInternalId(id), this->data_size_);
+            vectors_output.push_back(vec);
         }
     }
 #endif

src/VecSim/algorithms/hnsw/hnsw_single.h

@@ -35,13 +35,13 @@ class HNSWIndex_Single : public HNSWIndex<DataType, DistType> {
         : HNSWIndex<DataType, DistType>(input, params, allocator, version),
           label_lookup_(this->max_elements_, allocator) {}
 
-    void getDataByLabel(labelType label, std::vector<const char *> &vectors_output) const {
+    void GetDataByLabel(labelType label, std::vector<std::vector<DataType>> &vectors_output) {
 
         auto id = label_lookup_.at(label);
 
-        auto *vec_copy = new DataType[this->dim];
-        memcpy(vec_copy, this->getDataByInternalId(id), this->data_size_);
-        vectors_output.push_back((const char *)vec_copy);
+        auto vec = std::vector<DataType>(this->dim);
+        memcpy(vec.data(), this->getDataByInternalId(id), this->data_size_);
+        vectors_output.push_back(vec);
     }
 #endif
     ~HNSWIndex_Single() {}

src/VecSim/algorithms/hnsw/hnsw_single_tests_friends.h

@@ -10,4 +10,4 @@ INDEX_TEST_FRIEND_CLASS(HNSWTest_preferAdHocOptimization_Test)
 INDEX_TEST_FRIEND_CLASS(HNSWTest_testSizeEstimation_Test)
 INDEX_TEST_FRIEND_CLASS(IndexAllocatorTest_testIncomingEdgesSet_Test)
 INDEX_TEST_FRIEND_CLASS(IndexAllocatorTest_test_hnsw_reclaim_memory_Test)
-INDEX_TEST_FRIEND_CLASS(HNSWTestParallel_parallelInsertSearch_Test)
+INDEX_TEST_FRIEND_CLASS(HNSWTestParallel_parallelInsertSearch_Test)

src/VecSim/algorithms/hnsw/hnsw_tiered.h

@@ -72,7 +72,4 @@ class TieredHNSWIndex : public VecSimTieredIndex<DataType, DistType> {
     inline void setLastSearchMode(VecSearchMode mode) override {
         return this->index->setLastSearchMode(mode);
     }
-    void getDataByLabel(labelType label, std::vector<const char *> &vectors_output) const override {
-
-    }
 };

src/VecSim/vec_sim_interface.h

@@ -12,7 +12,6 @@
 
 #include <stddef.h>
 #include <stdexcept>
-#include <vector>
 /**
  * @brief Abstract C++ class for vector index, delete and lookup
  *
@@ -177,16 +176,4 @@ struct VecSimIndexInterface : public VecsimBaseObject {
     inline static void setTimeoutCallbackFunction(timeoutCallbackFunction callback) {
         VecSimIndexInterface::timeoutCallback = callback;
     }
-#ifdef BUILD_TESTS
-    /**
-     * @brief Used for testing - store vector(s) data associated with a given label. This function
-     * copies the vector(s)' data buffer(s) and place its pointer(s) in the output vector
-     *
-     * @param label
-     * @param vectors_output empty vector to be modified, should store the blob(s) associated with
-     * the label.
-     */
-    virtual void getDataByLabel(labelType label,
-                                std::vector<const char *> &vectors_output) const = 0;
-#endif
 };

src/python_bindings/Mybytearray.py

@@ -0,0 +1,3 @@
+
+def create_bytearray(np_arr):
+        return bytearray(np_arr)