Improve type hints in sfWebResponse

nederdirk · nederdirk · commit f28e80069381 · 2018-03-13T14:11:09.000+01:00
diff --git a/lib/response/sfWebResponse.class.php b/lib/response/sfWebResponse.class.php
@@ -193,7 +193,7 @@ public function setCookie($name, $value, $expire = null, $path = '/', $domain =
   /**
    * Sets response status code.
    *
-   * @param string $code  HTTP status code
+   * @param int $code  HTTP status code
    * @param string $name  HTTP status text
    *
    */
@@ -227,7 +227,7 @@ public function getStatusCode()
    * Sets a HTTP header.
    *
    * @param string  $name     HTTP header name
-   * @param string  $value    Value (if null, remove the HTTP header)
+   * @param string|null  $value    Value (if null, remove the HTTP header)
    * @param bool    $replace  Replace for the value
    *
    */

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,7 @@ public function setCookie($name, $value, $expire = null, $path = '/', $domain =`
`193`	`193`	`/**`
`194`	`194`	`* Sets response status code.`
`195`	`195`	`*`
`196`		`- * @param string $code HTTP status code`
	`196`	`+ * @param int $code HTTP status code`
`197`	`197`	`* @param string $name HTTP status text`
`198`	`198`	`*`
`199`	`199`	`*/`
`@@ -227,7 +227,7 @@ public function getStatusCode()`
`227`	`227`	`* Sets a HTTP header.`
`228`	`228`	`*`
`229`	`229`	`* @param string $name HTTP header name`
`230`		`- * @param string $value Value (if null, remove the HTTP header)`
	`230`	`+ * @param string\|null $value Value (if null, remove the HTTP header)`
`231`	`231`	`* @param bool $replace Replace for the value`
`232`	`232`	`*`
`233`	`233`	`*/`