Use delegating ctors + other ctor cleanup

Found two places where delegating constructors helped: ray and
checker_texture.

In addition, this includes some minor constructor cleanup.

Resolves #1489

Author: hollasch

books/RayTracingTheNextWeek.html

@@ -75,11 +75,11 @@
 
 
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
-        ray(const point3& origin, const vec3& direction)
-          : orig(origin), dir(direction), tm(0) {}
-
         ray(const point3& origin, const vec3& direction, double time)
           : orig(origin), dir(direction), tm(time) {}
+
+        ray(const point3& origin, const vec3& direction)
+          : ray(origin, direction, 0) {}
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
 
         const point3& origin() const  { return orig; }
@@ -1323,10 +1323,7 @@
           : inv_scale(1.0 / scale), even(even), odd(odd) {}
 
         checker_texture(double scale, const color& c1, const color& c2)
-          : inv_scale(1.0 / scale),
-            even(make_shared<solid_color>(c1)),
-            odd(make_shared<solid_color>(c2))
-        {}
+          : checker_texture(scale, make_shared<solid_color>(c1), make_shared<solid_color>(c2)) {}
 
         color value(double u, double v, const point3& p) const override {
             auto xInteger = int(std::floor(inv_scale * p.x()));
@@ -2252,9 +2249,6 @@
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
     class noise_texture : public texture {
       public:
-        noise_texture() {}
-
-
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
         noise_texture(double scale) : scale(scale) {}
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
@@ -2449,8 +2443,6 @@
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
     class noise_texture : public texture {
       public:
-        noise_texture() {}
-
         noise_texture(double scale) : scale(scale) {}
 
         color value(double u, double v, const point3& p) const override {
@@ -2515,8 +2507,6 @@
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
     class noise_texture : public texture {
       public:
-        noise_texture() {}
-
         noise_texture(double scale) : scale(scale) {}
 
         color value(double u, double v, const point3& p) const override {
@@ -2552,8 +2542,6 @@
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
     class noise_texture : public texture {
       public:
-        noise_texture() {}
-
         noise_texture(double scale) : scale(scale) {}
 
         color value(double u, double v, const point3& p) const override {

books/RayTracingTheRestOfYourLife.html

@@ -2710,7 +2710,7 @@
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
     class sphere_pdf : public pdf {
       public:
-        sphere_pdf() { }
+        sphere_pdf() {}
 
         double value(const vec3& direction) const override {
             return 1/ (4 * pi);

src/TheNextWeek/ray.h

@@ -18,12 +18,12 @@ class ray {
   public:
     ray() {}
 
-    ray(const point3& origin, const vec3& direction)
-      : orig(origin), dir(direction), tm(0) {}
-
     ray(const point3& origin, const vec3& direction, double time)
       : orig(origin), dir(direction), tm(time) {}
 
+    ray(const point3& origin, const vec3& direction)
+      : ray(origin, direction, 0) {}
+
     const point3& origin() const  { return orig; }
     const vec3& direction() const { return dir; }
 

src/TheNextWeek/texture.h

@@ -46,10 +46,7 @@ class checker_texture : public texture {
       : inv_scale(1.0 / scale), even(even), odd(odd) {}
 
     checker_texture(double scale, const color& c1, const color& c2)
-      : inv_scale(1.0 / scale),
-        even(make_shared<solid_color>(c1)),
-        odd(make_shared<solid_color>(c2))
-    {}
+      : checker_texture(scale, make_shared<solid_color>(c1), make_shared<solid_color>(c2)) {}
 
     color value(double u, double v, const point3& p) const override {
         auto xInteger = int(std::floor(inv_scale * p.x()));
@@ -95,8 +92,6 @@ class image_texture : public texture {
 
 class noise_texture : public texture {
   public:
-    noise_texture() {}
-
     noise_texture(double scale) : scale(scale) {}
 
     color value(double u, double v, const point3& p) const override {

src/TheRestOfYourLife/pdf.h

@@ -46,7 +46,7 @@ class cosine_pdf : public pdf {
 
 class sphere_pdf : public pdf {
   public:
-    sphere_pdf() { }
+    sphere_pdf() {}
 
     double value(const vec3& direction) const override {
         return 1/ (4 * pi);

src/TheRestOfYourLife/ray.h

@@ -18,12 +18,12 @@ class ray {
   public:
     ray() {}
 
-    ray(const point3& origin, const vec3& direction)
-      : orig(origin), dir(direction), tm(0) {}
-
     ray(const point3& origin, const vec3& direction, double time)
       : orig(origin), dir(direction), tm(time) {}
 
+    ray(const point3& origin, const vec3& direction)
+      : ray(origin, direction, 0) {}
+
     const point3& origin() const  { return orig; }
     const vec3& direction() const { return dir; }
 

src/TheRestOfYourLife/texture.h

@@ -46,10 +46,7 @@ class checker_texture : public texture {
       : inv_scale(1.0 / scale), even(even), odd(odd) {}
 
     checker_texture(double scale, const color& c1, const color& c2)
-      : inv_scale(1.0 / scale),
-        even(make_shared<solid_color>(c1)),
-        odd(make_shared<solid_color>(c2))
-    {}
+      : checker_texture(scale, make_shared<solid_color>(c1), make_shared<solid_color>(c2)) {}
 
     color value(double u, double v, const point3& p) const override {
         auto xInteger = int(std::floor(inv_scale * p.x()));
@@ -95,8 +92,6 @@ class image_texture : public texture {
 
 class noise_texture : public texture {
   public:
-    noise_texture() {}
-
     noise_texture(double scale) : scale(scale) {}
 
     color value(double u, double v, const point3& p) const override {