Resolves #1483

Author: rupsis

books/RayTracingTheNextWeek.html

@@ -1989,21 +1989,13 @@
     class perlin {
       public:
         perlin() {
-            randfloat = new double[point_count];
             for (int i = 0; i < point_count; i++) {
                 randfloat[i] = random_double();
             }
 
-            perm_x = perlin_generate_perm();
-            perm_y = perlin_generate_perm();
-            perm_z = perlin_generate_perm();
-        }
-
-        ~perlin() {
-            delete[] randfloat;
-            delete[] perm_x;
-            delete[] perm_y;
-            delete[] perm_z;
+            perlin_generate_perm(perm_x);
+            perlin_generate_perm(perm_y);
+            perlin_generate_perm(perm_z);
         }
 
         double noise(const point3& p) const {
@@ -2016,20 +2008,16 @@
 
       private:
         static const int point_count = 256;
-        double* randfloat;
-        int* perm_x;
-        int* perm_y;
-        int* perm_z;
-
-        static int* perlin_generate_perm() {
-            auto p = new int[point_count];
+        double randfloat[point_count];
+        int perm_x[point_count];
+        int perm_y[point_count];
+        int perm_z[point_count];
 
+        static void perlin_generate_perm(int* p) {
             for (int i = 0; i < point_count; i++)
                 p[i] = i;
 
             permute(p, point_count);
-
-            return p;
         }
 
         static void permute(int* p, int n) {
@@ -2309,39 +2297,27 @@
     class perlin {
       public:
         perlin() {
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
-            randvec = new vec3[point_count];
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
             for (int i = 0; i < point_count; i++) {
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
                 randvec[i] = unit_vector(vec3::random(-1,1));
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
             }
 
-            perm_x = perlin_generate_perm();
-            perm_y = perlin_generate_perm();
-            perm_z = perlin_generate_perm();
-        }
-
-        ~perlin() {
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
-            delete[] randvec;
-    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
-            delete[] perm_x;
-            delete[] perm_y;
-            delete[] perm_z;
+            perlin_generate_perm(perm_x);
+            perlin_generate_perm(perm_y);
+            perlin_generate_perm(perm_z);
         }
 
         ...
 
       private:
         static const int point_count = 256;
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++ highlight
-        vec3* randvec;
+        vec3 randvec[point_count];
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ C++
-        int* perm_x;
-        int* perm_y;
-        int* perm_z;
+        int perm_x[point_count];
+        int perm_y[point_count];
+        int perm_z[point_count];
         ...
     };
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/TheNextWeek/perlin.h

@@ -17,21 +17,13 @@
 class perlin {
   public:
     perlin() {
-        randvec = new vec3[point_count];
         for (int i = 0; i < point_count; i++) {
             randvec[i] = unit_vector(vec3::random(-1,1));
         }
 
-        perm_x = perlin_generate_perm();
-        perm_y = perlin_generate_perm();
-        perm_z = perlin_generate_perm();
-    }
-
-    ~perlin() {
-        delete[] randvec;
-        delete[] perm_x;
-        delete[] perm_y;
-        delete[] perm_z;
+        perlin_generate_perm(perm_x);
+        perlin_generate_perm(perm_y);
+        perlin_generate_perm(perm_z);
     }
 
     double noise(const point3& p) const {
@@ -72,20 +64,16 @@ class perlin {
 
   private:
     static const int point_count = 256;
-    vec3* randvec;
-    int* perm_x;
-    int* perm_y;
-    int* perm_z;
-
-    static int* perlin_generate_perm() {
-        auto p = new int[point_count];
+    vec3 randvec[point_count];
+    int perm_x[point_count];
+    int perm_y[point_count];
+    int perm_z[point_count];
 
+    static void perlin_generate_perm(int* p) {
         for (int i = 0; i < point_count; i++)
             p[i] = i;
 
         permute(p, point_count);
-
-        return p;
     }
 
     static void permute(int* p, int n) {

src/TheRestOfYourLife/perlin.h

@@ -17,21 +17,13 @@
 class perlin {
   public:
     perlin() {
-        randvec = new vec3[point_count];
         for (int i = 0; i < point_count; i++) {
             randvec[i] = unit_vector(vec3::random(-1,1));
         }
 
-        perm_x = perlin_generate_perm();
-        perm_y = perlin_generate_perm();
-        perm_z = perlin_generate_perm();
-    }
-
-    ~perlin() {
-        delete[] randvec;
-        delete[] perm_x;
-        delete[] perm_y;
-        delete[] perm_z;
+        perlin_generate_perm(perm_x);
+        perlin_generate_perm(perm_y);
+        perlin_generate_perm(perm_z);
     }
 
     double noise(const point3& p) const {
@@ -72,20 +64,16 @@ class perlin {
 
   private:
     static const int point_count = 256;
-    vec3* randvec;
-    int* perm_x;
-    int* perm_y;
-    int* perm_z;
-
-    static int* perlin_generate_perm() {
-        auto p = new int[point_count];
+    vec3 randvec[point_count];
+    int perm_x[point_count];
+    int perm_y[point_count];
+    int perm_z[point_count];
 
+    static void perlin_generate_perm(int* p) {
         for (int i = 0; i < point_count; i++)
             p[i] = i;
 
         permute(p, point_count);
-
-        return p;
     }
 
     static void permute(int* p, int n) {