feat(cursors): fix handling errors

Author: Varixo

packages/qwik/src/core/client/vnode-diff.ts

@@ -50,7 +50,7 @@ import {
   QTemplate,
   dangerouslySetInnerHTML,
 } from '../shared/utils/markers';
-import { isPromise, retryOnPromise } from '../shared/utils/promises';
+import { isPromise, retryOnPromise, safeCall } from '../shared/utils/promises';
 import { isSlotProp } from '../shared/utils/prop';
 import { hasClassAttr } from '../shared/utils/scoped-styles';
 import { serializeAttribute } from '../shared/utils/styles';
@@ -813,7 +813,13 @@ export const vnode_diff = (
 
           for (const qrl of qrls.flat(2)) {
             if (qrl) {
-              qrl(event, element);
+              safeCall(
+                () => qrl(event, element),
+                () => {},
+                (e) => {
+                  container.handleError(e, vNode);
+                }
+              );
             }
           }
         };
@@ -917,7 +923,7 @@ export const vnode_diff = (
         if (newValue !== oldAttrs[key]) {
           isEvent ? recordJsxEvent(key, newValue) : record(key, newValue);
         }
-      } else {
+      } else if (newValue != null) {
         isEvent ? recordJsxEvent(key, newValue) : record(key, newValue);
       }
     }

packages/qwik/src/core/shared/cursor/chore-execution.ts

@@ -193,7 +193,6 @@ export function executeComponentChore(
     },
     (err: any) => {
       container.handleError(err, host);
-      throw err;
     }
   );
 

packages/qwik/src/core/tests/container.spec.tsx

@@ -1,13 +1,12 @@
 import { walkJSX } from '@qwik.dev/core/testing';
 import crypto from 'node:crypto';
-import { describe, expect, it, vi } from 'vitest';
+import { describe, expect, it } from 'vitest';
 import { ssrCreateContainer } from '../../server/ssr-container';
 import { SsrNode } from '../../server/ssr-node';
 import { createDocument } from '../../testing/document';
 import { getDomContainer } from '../client/dom-container';
 import type { ClientContainer } from '../client/types';
-import { vnode_getFirstChild, vnode_getText } from '../client/vnode';
-import type { VNode } from '../client/vnode-impl';
+import { vnode_getFirstChild, vnode_getProp, vnode_getText } from '../client/vnode';
 import { createComputed$, createSignal } from '../reactive-primitives/signal.public';
 import { SignalFlags } from '../reactive-primitives/types';
 import { SERIALIZABLE_STATE, component$ } from '../shared/component.public';
@@ -23,11 +22,7 @@ import { TypeIds } from '../shared/serdes/constants';
 import { hasClassAttr } from '../shared/utils/scoped-styles';
 import { type SSRContainer } from '../ssr/ssr-types';
 import { toSsrAttrs } from '../ssr/ssr-render-jsx';
-
-vi.hoisted(() => {
-  vi.stubGlobal('QWIK_LOADER_DEFAULT_MINIFIED', 'min');
-  vi.stubGlobal('QWIK_LOADER_DEFAULT_DEBUG', 'debug');
-});
+import type { VNode } from '../shared/vnode/vnode';
 
 describe('serializer v2', () => {
   describe('rendering', () => {
@@ -131,7 +126,7 @@ describe('serializer v2', () => {
           ssr.closeElement();
         });
         const vnodeSpan: VNode = await clientContainer.$getObjectById$(0).someProp;
-        expect(vnodeSpan.getAttr('id')).toBe('myId');
+        expect(vnode_getProp(vnodeSpan, 'id', null)).toBe('myId');
       });
       it('should retrieve text node', async () => {
         const clientContainer = await withContainer((ssr) => {

packages/qwik/src/core/tests/projection.spec.tsx

@@ -21,7 +21,7 @@ import {
 import { domRender, ssrRenderToDom, trigger } from '@qwik.dev/core/testing';
 import { cleanupAttrs } from 'packages/qwik/src/testing/element-fixture';
 import { beforeEach, describe, expect, it } from 'vitest';
-import { vnode_locate } from '../client/vnode';
+import { vnode_getProp, vnode_locate } from '../client/vnode';
 import { HTML_NS, QContainerAttr, SVG_NS } from '../shared/utils/markers';
 import { QContainerValue } from '../shared/types';
 
@@ -2280,7 +2280,7 @@ describe.each([
 
     if (ssrRenderToDom === render) {
       const CmpVNode = vnode_locate(container.rootVNode, '4A');
-      const renderProp = CmpVNode.getProp('q:renderFn', null);
+      const renderProp = vnode_getProp(CmpVNode, 'q:renderFn', null);
       expect(renderProp).not.toBeNull();
     }
   });