Skip to content

Commit 1849a46

Browse files
author
Igor Khomenko
committed
Merge pull request #87 from QuickBlox/develop.webrtc.bug_fixing.07122015
bug fixing from 07122015
2 parents 306c121 + 9627260 commit 1849a46

File tree

4 files changed

+36
-17
lines changed

4 files changed

+36
-17
lines changed

js/modules/webrtc/qbWebRTCSession.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ WebRTCSession.prototype.accept = function(extension) {
251251
oppIDs.forEach(function(opID, i, arr) {
252252
if(self.currentUserID > opID){
253253
// call to the user
254-
self._callInternal(opID, {}, false);
254+
self._callInternal(opID, {}, true);
255255
}
256256
});
257257
}

js/modules/webrtc/qbWebRTCSignalingProcessor.js

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,18 @@ function WebRTCSignalingProcessor(service, delegate, connection) {
113113

114114
} else {
115115
if (extraParams.childNodes[i].childNodes.length > 1) {
116-
117-
extension = self._XMLtoJS(extension, extraParams.childNodes[i].tagName, extraParams.childNodes[i]);
118-
116+
var nodeTextContentSize = extraParams.childNodes[i].textContent.length;
117+
118+
if (nodeTextContentSize > 4096) {
119+
var wholeNodeContent = "";
120+
121+
for(var t=0; t<extraParams.childNodes[i].childNodes.length; ++t){
122+
wholeNodeContent += extraParams.childNodes[i].childNodes[t].textContent;
123+
}
124+
extension[extraParams.childNodes[i].tagName] = wholeNodeContent;
125+
}else {
126+
extension = self._XMLtoJS(extension, extraParams.childNodes[i].tagName, extraParams.childNodes[i]);
127+
}
119128
} else {
120129

121130
extension[extraParams.childNodes[i].tagName] = extraParams.childNodes[i].textContent;

quickblox.min.js

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

samples/webrtc/app.js

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,10 @@
101101
}
102102
}
103103
},
104+
classesNameFilter: 'no aden reyes perpetua inkwell toaster walden hudson gingham mayfair lofi xpro2 _1977 brooklyn',
104105
changeFilter: function(selector, filterName) {
105-
var classesNameAll = 'no aden reyes perpetua inkwell toaster walden hudson gingham mayfair lofi xpro2 _1977 brooklyn';
106-
107106
$(selector)
108-
.removeClass(classesNameAll)
107+
.removeClass(this.classesNameFilter)
109108
.addClass( filterName );
110109
},
111110
callTime: 0,
@@ -372,18 +371,29 @@
372371
/** set main video */
373372
$(document).on('click', '.j-callees__callee_video', function() {
374373
var $that = $(this),
375-
userID = +($(this).data('user'));
374+
userID = +($(this).data('user')),
375+
classesName = [],
376+
activeClass = [];
376377

377378
if( app.currentSession.peerConnections[userID].stream ) {
378379
if( $that.hasClass('active') ) {
379380
$that.removeClass('active');
380381

381382
app.currentSession.detachMediaStream('main_video');
383+
ui.changeFilter('#main_video', 'no');
382384
app.mainVideo = 0;
383385
} else {
384386
$('.j-callees__callee_video').removeClass('active');
385387
$that.addClass('active');
386388

389+
ui.changeFilter('#main_video', 'no');
390+
391+
activeClass = _.intersection($that.attr('class').split(/\s+/), ui.classesNameFilter.split(/\s+/) );
392+
393+
/** set filter to main video if exist */
394+
if(activeClass.length) {
395+
ui.changeFilter('#main_video', activeClass[0]);
396+
}
387397
app.currentSession.attachMediaStream('main_video', app.currentSession.peerConnections[userID].stream);
388398
app.mainVideo = userID;
389399
}
@@ -605,7 +615,7 @@
605615

606616
if(connectionState === QB.webrtc.SessionConnectionState.DISCONNECTED){
607617
ui.toggleRemoteVideoView(userID, 'hide');
608-
$calleeStatus.text('Hung Up');
618+
$calleeStatus.text('disconnected');
609619
}
610620

611621
if(connectionState === QB.webrtc.SessionConnectionState.CLOSED){

0 commit comments

Comments
 (0)