feat: Add remote management, fetch, and push subcommands #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implement remote add/remove/rename/set-url/show operations - Add fetch and push subcommands for remote synchronization - Create remote_wrapper class for RAII management - Add comprehensive test suite (19 tests, all passing) - Fix CMakeLists.txt to find CLI11 in conda/pixi environment Signed-off-by: Julien Jerphanion <git@jjerphan.xyz>
jjerphan
force-pushed
the
feat/remotes
branch
from
fa573f4 to
6ef5d64
Compare
JohanMabille
reviewed
Dec 1, 2025
src/subcommand/fetch_subcommand.cpp
Outdated
| int sideband_progress(const char* str, int len, void*) | ||
| { | ||
| printf("remote: %.*s", len, str); | ||
| fflush(stdout); |
Member
There was a problem hiding this comment.
Prefer C++ standard streams.
Member
Author
There was a problem hiding this comment.
Yes, I think the agent adopted some of the style of the codebase which uses printf:
ag printf
src/subcommand/clone_subcommand.cpp
21: printf("remote: %.*s", len, str);
src/subcommand/merge_subcommand.cpp
173: printf("Merge made\n");
src/subcommand/fetch_subcommand.cpp
Outdated
|
|
||
| if (git_oid_is_zero(a)) | ||
| { | ||
| printf("[new] %.20s %s\n", b_str, refname); |
Member
There was a problem hiding this comment.
Prefer C++ standard streams.
src/subcommand/fetch_subcommand.cpp
Outdated
| { | ||
| git_oid_fmt(a_str, a); | ||
| a_str[GIT_OID_SHA1_HEXSIZE] = '\0'; | ||
| printf("[updated] %.10s..%.10s %s\n", a_str, b_str, refname); |
src/subcommand/fetch_subcommand.cpp
Outdated
|
|
||
| int fetch_progress(const git_indexer_progress* stats, void* payload) | ||
| { | ||
| static bool done = false; |
Member
There was a problem hiding this comment.
Notice that this will prevent to use this function with many fetches . Since we're not going to implement it in this PR, I think it's fine for now, but you should add a note about it, stating this needs refactoring in order to be usable from mutiple fetches.
Member
Author
There was a problem hiding this comment.
I agree. The agent must have taken some inspiration from those current uses.
Signed-off-by: Julien Jerphanion <git@jjerphan.xyz> Co-authored-by: Johan Mabille <johan.mabille@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add,remove,rename,set-url,showoperationsfetchandpushsubcommands for remote synchronizationremote_wrapperclass for RAII managementNote that 6ef5d64 was generated.