refactor!: properly type MISSING #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors type annotations for parameters that previously defaulted to MISSING by augmenting them with a union involving utils.Undefined. This change is applied consistently across multiple modules (e.g. member, interactions, integrations, HTTP, guild, etc.) to improve clarity and type safety of optional parameters.
- Updated function signatures to include unions like “… | utils.Undefined” for optional parameters.
- Changes span core modules and extensions, ensuring that the new typing pattern is applied uniformly.
- The refactor is intended to improve API clarity and maintainability without altering the runtime behavior.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| discord/member.py | Updated edit() parameters to include union with utils.Undefined |
| discord/interactions.py | Modified message editing parameters with extended type unions |
| discord/integrations.py | Similar changes to optional parameters using utils.Undefined |
| discord/http.py | Updated session initialization signature to use the new union type |
| discord/guild.py | Revised channel creation and edit methods with proper type unions |
| ... (other files updated similarly) | Consistent application of new union annotations across modules |
Member
|
i didnt actually test this, i'm just assuming you're right |
Author
I started my bot and it worked, so it should be fine since no logic is changed |
Member
|
@plun1331 What was breaking here ? Just the type change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.