Merge pull request #4306 from PowerShell/andschwa/auto-update

Rewrite `UpdatePowerShell` feature

Author: andyleejordan

.vsts-ci/templates/ci-general.yml

@@ -70,6 +70,7 @@ steps:
   inputs:
     targetType: inline
     script: |
+      Get-ChildItem env:
       Get-Module -ListAvailable Pester
       Install-Module InvokeBuild -Scope CurrentUser -Force
       Install-Module platyPS -Scope CurrentUser -Force

src/features/Console.ts

@@ -5,7 +5,7 @@ import vscode = require("vscode");
 import { NotificationType, RequestType } from "vscode-languageclient";
 import { LanguageClient } from "vscode-languageclient/node";
 import { ICheckboxQuickPickItem, showCheckboxQuickPick } from "../controls/checkboxQuickPick";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { getSettings } from "../settings";
 import { LanguageClientConsumer } from "../languageClientConsumer";
 
@@ -170,7 +170,7 @@ export class ConsoleFeature extends LanguageClientConsumer {
     private commands: vscode.Disposable[];
     private handlers: vscode.Disposable[] = [];
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
         this.commands = [
             vscode.commands.registerCommand("PowerShell.RunSelection", async () => {

src/features/DebugSession.ts

@@ -12,7 +12,7 @@ import { getPlatformDetails, OperatingSystem } from "../platform";
 import { PowerShellProcess } from "../process";
 import { IEditorServicesSessionDetails, SessionManager, SessionStatus } from "../session";
 import { getSettings } from "../settings";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { LanguageClientConsumer } from "../languageClientConsumer";
 import path = require("path");
 import utils = require("../utils");
@@ -65,7 +65,7 @@ export class DebugSessionFeature extends LanguageClientConsumer
         },
     };
 
-    constructor(context: ExtensionContext, private sessionManager: SessionManager, private logger: Logger) {
+    constructor(context: ExtensionContext, private sessionManager: SessionManager, private logger: ILogger) {
         super();
         // Register a debug configuration provider
         context.subscriptions.push(vscode.debug.registerDebugConfigurationProvider("PowerShell", this));
@@ -359,7 +359,7 @@ export class PickPSHostProcessFeature extends LanguageClientConsumer {
     private waitingForClientToken?: vscode.CancellationTokenSource;
     private getLanguageClientResolve?: (value: LanguageClient) => void;
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
 
         this.command =
@@ -485,7 +485,7 @@ export class PickRunspaceFeature extends LanguageClientConsumer {
     private waitingForClientToken?: vscode.CancellationTokenSource;
     private getLanguageClientResolve?: (value: LanguageClient) => void;
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
         this.command =
             vscode.commands.registerCommand("PowerShell.PickRunspace", (processId) => {

src/features/ExtensionCommands.ts

@@ -9,7 +9,7 @@ import {
     Position, Range, RequestType
 } from "vscode-languageclient";
 import { LanguageClient } from "vscode-languageclient/node";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { getSettings, validateCwdSetting } from "../settings";
 import { LanguageClientConsumer } from "../languageClientConsumer";
 
@@ -149,7 +149,7 @@ export class ExtensionCommandsFeature extends LanguageClientConsumer {
     private handlers: vscode.Disposable[] = [];
     private extensionCommands: IExtensionCommand[] = [];
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
         this.commands = [
             vscode.commands.registerCommand("PowerShell.ShowAdditionalCommands", async () => {

src/features/ExternalApi.ts

@@ -4,7 +4,7 @@
 import * as vscode from "vscode";
 import { v4 as uuidv4 } from "uuid";
 import { LanguageClientConsumer } from "../languageClientConsumer";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { SessionManager } from "../session";
 
 export interface IExternalPowerShellDetails {
@@ -39,7 +39,7 @@ export class ExternalApiFeature extends LanguageClientConsumer implements IPower
     constructor(
         private extensionContext: vscode.ExtensionContext,
         private sessionManager: SessionManager,
-        private logger: Logger) {
+        private logger: ILogger) {
         super();
     }
 

src/features/GetCommands.ts

@@ -4,7 +4,7 @@
 import * as vscode from "vscode";
 import { RequestType0 } from "vscode-languageclient";
 import { LanguageClient } from "vscode-languageclient/node";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { LanguageClientConsumer } from "../languageClientConsumer";
 import { getSettings } from "../settings";
 
@@ -30,7 +30,7 @@ export class GetCommandsFeature extends LanguageClientConsumer {
     private commandsExplorerProvider: CommandsExplorerProvider;
     private commandsExplorerTreeView: vscode.TreeView<Command>;
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
         this.commands = [
             vscode.commands.registerCommand("PowerShell.RefreshCommandsExplorer",

src/features/NewFileOrProject.ts

@@ -5,15 +5,15 @@ import vscode = require("vscode");
 import { RequestType } from "vscode-languageclient";
 import { LanguageClient } from "vscode-languageclient/node";
 import { LanguageClientConsumer } from "../languageClientConsumer";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 
 export class NewFileOrProjectFeature extends LanguageClientConsumer {
 
     private readonly loadIcon = "  $(sync)  ";
     private command: vscode.Disposable;
     private waitingForClientToken?: vscode.CancellationTokenSource;
 
-    constructor(private logger: Logger) {
+    constructor(private logger: ILogger) {
         super();
         this.command =
             vscode.commands.registerCommand("PowerShell.NewProjectFromTemplate", async () => {

src/features/PesterTests.ts

@@ -3,7 +3,7 @@
 
 import * as path from "path";
 import vscode = require("vscode");
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { SessionManager } from "../session";
 import { getSettings, chosenWorkspace, validateCwdSetting } from "../settings";
 import utils = require("../utils");
@@ -17,7 +17,7 @@ export class PesterTestsFeature implements vscode.Disposable {
     private commands: vscode.Disposable[];
     private invokePesterStubScriptPath: string;
 
-    constructor(private sessionManager: SessionManager, private logger: Logger) {
+    constructor(private sessionManager: SessionManager, private logger: ILogger) {
         this.invokePesterStubScriptPath = path.resolve(__dirname, "../modules/PowerShellEditorServices/InvokePesterStub.ps1");
         this.commands = [
             // File context-menu command - Run Pester Tests

src/features/RunCode.ts

@@ -3,7 +3,7 @@
 
 import vscode = require("vscode");
 import { SessionManager } from "../session";
-import { Logger } from "../logging";
+import { ILogger } from "../logging";
 import { getSettings, chosenWorkspace, validateCwdSetting } from "../settings";
 
 enum LaunchType {
@@ -14,7 +14,7 @@ enum LaunchType {
 export class RunCodeFeature implements vscode.Disposable {
     private command: vscode.Disposable;
 
-    constructor(private sessionManager: SessionManager, private logger: Logger) {
+    constructor(private sessionManager: SessionManager, private logger: ILogger) {
         this.command = vscode.commands.registerCommand(
             "PowerShell.RunCode",
             async (runInDebugger: boolean, scriptToRun: string, args: string[]) => {