Import PSDesiredStateConfiguration by name

Instead of a hard-coded path which doesn't always work. Also apply
`ErrorAction -Ignore` fix to Plaster module.

Author: andyleejordan

src/PowerShellEditorServices/Services/PowerShell/Debugging/DscBreakpointCapability.cs

@@ -92,16 +92,17 @@ public static async Task<DscBreakpointCapability> GetDscCapabilityAsync(
             if (!isDscInstalled.HasValue)
             {
                 PSCommand psCommand = new PSCommand()
-                    .AddCommand("Import-Module")
-                    .AddArgument(@"C:\Program Files\DesiredStateConfiguration\1.0.0.0\Modules\PSDesiredStateConfiguration\PSDesiredStateConfiguration.psd1")
+                    .AddCommand("Microsoft.PowerShell.Core\\Import-Module")
+                    .AddParameter("-Name", "PSDesiredStateConfiguration")
                     .AddParameter("PassThru")
                     .AddParameter("ErrorAction", ActionPreference.Ignore);
 
                 IReadOnlyList<PSModuleInfo> dscModule =
                     await psesHost.ExecutePSCommandAsync<PSModuleInfo>(
                         psCommand,
                         CancellationToken.None,
-                        new PowerShellExecutionOptions { ThrowOnError = false }).ConfigureAwait(false);
+                        new PowerShellExecutionOptions { ThrowOnError = false })
+                    .ConfigureAwait(false);
 
                 isDscInstalled = dscModule.Count > 0;
                 logger.LogTrace("Side-by-side DSC module found: " + isDscInstalled.Value);

src/PowerShellEditorServices/Services/Template/TemplateService.cs

@@ -74,7 +74,10 @@ public async Task<bool> ImportPlasterIfInstalledAsync()
 
                 IReadOnlyList<PSObject> moduleObject =
                     await _executionService.ExecutePSCommandAsync<PSObject>(
-                        psCommand, CancellationToken.None).ConfigureAwait(false);
+                        psCommand,
+                        CancellationToken.None,
+                        new PowerShellExecutionOptions { ThrowOnError = false })
+                    .ConfigureAwait(false);
 
                 isPlasterInstalled = moduleObject.Count > 0;
                 _logger.LogTrace("Plaster installed: " + isPlasterInstalled.Value);
@@ -86,13 +89,19 @@ await _executionService.ExecutePSCommandAsync<PSObject>(
 
                     psCommand = new PSCommand();
                     psCommand
-                        .AddCommand("Import-Module")
+                        .AddCommand("Microsoft.PowerShell.Core\\Import-Module")
                         .AddParameter("ModuleInfo", (PSModuleInfo)moduleObject[0].ImmediateBaseObject)
-                        .AddParameter("PassThru");
+                        .AddParameter("PassThru")
+                        .AddParameter("ErrorAction", ActionPreference.Ignore);
 
-                    IReadOnlyList<PSModuleInfo> importResult = await _executionService.ExecutePSCommandAsync<PSModuleInfo>(psCommand, CancellationToken.None).ConfigureAwait(false);
+                    IReadOnlyList<PSModuleInfo> plasterModule =
+                        await _executionService.ExecutePSCommandAsync<PSModuleInfo>(
+                            psCommand,
+                            CancellationToken.None,
+                            new PowerShellExecutionOptions { ThrowOnError = false })
+                        .ConfigureAwait(false);
 
-                    isPlasterLoaded = importResult.Count > 0;
+                    isPlasterLoaded = plasterModule.Count > 0;
                     _logger.LogTrace("Plaster loaded: " + isPlasterLoaded);
                 }
             }