Fix #130: Reduce prompt noise in debug adapter

This change keeps the debug adapter from printing the prompt until the
user enters a command.  This will allow breakpoints to be hit without the
prompt being shown every time.  The change also trims the ending '>'
character off of the end of the prompt to reduce user confusion about
where commands should be typed.

Author: daviwil

src/PowerShellEditorServices/Session/PowerShellContext.cs

@@ -905,10 +905,15 @@ private void WritePromptToHost(Func<PSCommand, string> invokeAction)
                 Environment.NewLine,
                 false);
 
+            // Trim the '>' off the end of the prompt string to reduce
+            // user confusion about where they can type.
+            // TODO: Eventually put this behind a setting, #133
+            promptString = promptString.TrimEnd(' ', '>', '\r', '\n');
+
             // Write the prompt string
             this.WriteOutput(
                 promptString,
-                false);
+                true);
         }
 
         private void WritePromptWithRunspace(Runspace runspace)
@@ -974,7 +979,8 @@ private void OnDebuggerStop(object sender, DebuggerStopEventArgs e)
                     null));
 
             // Write out the debugger prompt
-            this.WritePromptWithNestedPipeline();
+            // TODO: Eventually re-enable this and put it behind a setting, #133
+            //this.WritePromptWithNestedPipeline();
 
             // Raise the event for the debugger service
             if (this.DebuggerStop != null)

test/PowerShellEditorServices.Test/Console/ConsoleServiceTests.cs

@@ -79,9 +79,9 @@ await this.powerShellContext.ExecuteScriptString(
                         new string[] { Environment.NewLine },
                         StringSplitOptions.None);
 
-            // The output should be 3 lines: the expected string,
-            // an empty line, and the prompt string.
-            Assert.Equal(3, normalOutputLines.Length);
+            // The output should be 4 lines: the expected string, an
+            // empty line, the prompt string, and another empty line.
+            Assert.Equal(4, normalOutputLines.Length);
             Assert.Equal(
                 TestOutputString,
                 normalOutputLines[0]);