Replace superfluous Default member with default values (#1693)

andyleejordan · web-flow · commit 77d1ffcac2a5 · 2022-02-09T00:57:15.000Z
I think this was a case of premature optimization. We're using C#
records, which should be as cheap as an object as they come, especially
when we can rely on the compiler for default values. Now we're passing
fewer objects around too.
diff --git a/src/PowerShellEditorServices/Services/Extension/ExtensionService.cs b/src/PowerShellEditorServices/Services/Extension/ExtensionService.cs
@@ -107,7 +107,7 @@ internal Task InitializeAsync()
             // Register the editor object in the runspace
             return ExecutionService.ExecuteDelegateAsync(
                 $"Create ${PSEditorVariableName} object",
-                ExecutionOptions.Default,
+                executionOptions: null,
                 (pwsh, _) => pwsh.Runspace.SessionStateProxy.PSVariable.Set(psEditor),
                 CancellationToken.None);
         }
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Console/LegacyReadLine.cs b/src/PowerShellEditorServices/Services/PowerShell/Console/LegacyReadLine.cs
@@ -84,14 +84,14 @@ public override string ReadLine(CancellationToken cancellationToken)
                                         .AddParameter("CursorColumn", currentCursorIndex)
                                         .AddParameter("Options", null);
 
-                                    currentCompletion = _psesHost.InvokePSCommand<CommandCompletion>(command, PowerShellExecutionOptions.Default, cancellationToken).FirstOrDefault();
+                                    currentCompletion = _psesHost.InvokePSCommand<CommandCompletion>(command, executionOptions: null, cancellationToken).FirstOrDefault();
                                 }
                                 else
                                 {
                                     currentCompletion = _psesHost.InvokePSDelegate(
                                         "Legacy readline inline command completion",
-                                        ExecutionOptions.Default,
-                                        (pwsh, cancellationToken) => CommandCompletion.CompleteInput(inputAfterCompletion, currentCursorIndex, options: null, pwsh),
+                                        executionOptions: null,
+                                        (pwsh, _) => CommandCompletion.CompleteInput(inputAfterCompletion, currentCursorIndex, options: null, pwsh),
                                         cancellationToken);
 
                                     if (currentCompletion.CompletionMatches.Count > 0)
@@ -198,7 +198,7 @@ public override string ReadLine(CancellationToken cancellationToken)
                                 PSCommand command = new PSCommand()
                                     .AddCommand("Get-History");
 
-                                currentHistory = _psesHost.InvokePSCommand<PSObject>(command, PowerShellExecutionOptions.Default, cancellationToken);
+                                currentHistory = _psesHost.InvokePSCommand<PSObject>(command, executionOptions: null, cancellationToken);
 
                                 if (currentHistory != null)
                                 {
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Debugging/DscBreakpointCapability.cs b/src/PowerShellEditorServices/Services/PowerShell/Debugging/DscBreakpointCapability.cs
@@ -164,7 +164,7 @@ public static Task<DscBreakpointCapability> GetDscCapabilityAsync(
 
             return psesHost.ExecuteDelegateAsync<DscBreakpointCapability>(
                 nameof(getDscBreakpointCapabilityFunc),
-                ExecutionOptions.Default,
+                executionOptions: null,
                 getDscBreakpointCapabilityFunc,
                 cancellationToken);
         }
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Execution/ExecutionOptions.cs b/src/PowerShellEditorServices/Services/PowerShell/Execution/ExecutionOptions.cs
@@ -15,39 +15,16 @@ public enum ExecutionPriority
     // Generally the executor will do the right thing though; some options just priority over others.
     public record ExecutionOptions
     {
-        public static ExecutionOptions Default = new()
-        {
-            Priority = ExecutionPriority.Normal,
-            MustRunInForeground = false,
-            InterruptCurrentForeground = false,
-        };
-
-        public ExecutionPriority Priority { get; init; }
-
+        public ExecutionPriority Priority { get; init; } = ExecutionPriority.Normal;
         public bool MustRunInForeground { get; init; }
-
         public bool InterruptCurrentForeground { get; init; }
     }
 
     public record PowerShellExecutionOptions : ExecutionOptions
     {
-        public static new PowerShellExecutionOptions Default = new()
-        {
-            Priority = ExecutionPriority.Normal,
-            MustRunInForeground = false,
-            InterruptCurrentForeground = false,
-            WriteOutputToHost = false,
-            WriteInputToHost = false,
-            ThrowOnError = true,
-            AddToHistory = false,
-        };
-
         public bool WriteOutputToHost { get; init; }
-
         public bool WriteInputToHost { get; init; }
-
-        public bool ThrowOnError { get; init; }
-
+        public bool ThrowOnError { get; init; } = true;
         public bool AddToHistory { get; init; }
     }
 }
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousDelegateTask.cs b/src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousDelegateTask.cs
@@ -23,7 +23,7 @@ public SynchronousDelegateTask(
             CancellationToken cancellationToken)
             : base(logger, cancellationToken)
         {
-            ExecutionOptions = executionOptions;
+            ExecutionOptions = executionOptions ?? new ExecutionOptions();
             _representation = representation;
             _action = action;
         }
@@ -58,7 +58,7 @@ public SynchronousDelegateTask(
         {
             _func = func;
             _representation = representation;
-            ExecutionOptions = executionOptions;
+            ExecutionOptions = executionOptions ?? new ExecutionOptions();
         }
 
         public override ExecutionOptions ExecutionOptions { get; }
@@ -94,7 +94,7 @@ public SynchronousPSDelegateTask(
             _psesHost = psesHost;
             _action = action;
             _representation = representation;
-            ExecutionOptions = executionOptions;
+            ExecutionOptions = executionOptions ?? new ExecutionOptions();
         }
 
         public override ExecutionOptions ExecutionOptions { get; }
@@ -131,7 +131,7 @@ public SynchronousPSDelegateTask(
             _psesHost = psesHost;
             _func = func;
             _representation = representation;
-            ExecutionOptions = executionOptions;
+            ExecutionOptions = executionOptions ?? new ExecutionOptions();
         }
 
         public override ExecutionOptions ExecutionOptions { get; }
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousPowerShellTask.cs b/src/PowerShellEditorServices/Services/PowerShell/Execution/SynchronousPowerShellTask.cs
@@ -36,7 +36,7 @@ public SynchronousPowerShellTask(
             _logger = logger;
             _psesHost = psesHost;
             _psCommand = command;
-            PowerShellExecutionOptions = executionOptions;
+            PowerShellExecutionOptions = executionOptions ?? new PowerShellExecutionOptions();
         }
 
         public PowerShellExecutionOptions PowerShellExecutionOptions { get; }
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs b/src/PowerShellEditorServices/Services/PowerShell/Host/PsesInternalHost.cs
@@ -307,7 +307,8 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(
             Func<PowerShell, CancellationToken, TResult> func,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(
+                new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions, func, cancellationToken));
         }
 
         public Task ExecuteDelegateAsync(
@@ -316,7 +317,8 @@ public Task ExecuteDelegateAsync(
             Action<PowerShell, CancellationToken> action,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(
+                new SynchronousPSDelegateTask(_logger, this, representation, executionOptions, action, cancellationToken));
         }
 
         public Task<TResult> ExecuteDelegateAsync<TResult>(
@@ -325,7 +327,8 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(
             Func<CancellationToken, TResult> func,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(
+                new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions, func, cancellationToken));
         }
 
         public Task ExecuteDelegateAsync(
@@ -334,26 +337,26 @@ public Task ExecuteDelegateAsync(
             Action<CancellationToken> action,
             CancellationToken cancellationToken)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask(_logger, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(
+                new SynchronousDelegateTask(_logger, representation, executionOptions, action, cancellationToken));
         }
 
         public Task<IReadOnlyList<TResult>> ExecutePSCommandAsync<TResult>(
             PSCommand psCommand,
             CancellationToken cancellationToken,
             PowerShellExecutionOptions executionOptions = null)
         {
-            return InvokeTaskOnPipelineThreadAsync(new SynchronousPowerShellTask<TResult>(
-                _logger,
-                this,
-                psCommand,
-                executionOptions ?? PowerShellExecutionOptions.Default,
-                cancellationToken));
+            return InvokeTaskOnPipelineThreadAsync(
+                new SynchronousPowerShellTask<TResult>(_logger, this, psCommand, executionOptions, cancellationToken));
         }
 
         public Task ExecutePSCommandAsync(
             PSCommand psCommand,
             CancellationToken cancellationToken,
-            PowerShellExecutionOptions executionOptions = null) => ExecutePSCommandAsync<PSObject>(psCommand, cancellationToken, executionOptions);
+            PowerShellExecutionOptions executionOptions = null)
+        {
+            return ExecutePSCommandAsync<PSObject>(psCommand, cancellationToken, executionOptions);
+        }
 
         public TResult InvokeDelegate<TResult>(string representation, ExecutionOptions executionOptions, Func<CancellationToken, TResult> func, CancellationToken cancellationToken)
         {
@@ -374,7 +377,9 @@ public IReadOnlyList<TResult> InvokePSCommand<TResult>(PSCommand psCommand, Powe
         }
 
         public void InvokePSCommand(PSCommand psCommand, PowerShellExecutionOptions executionOptions, CancellationToken cancellationToken)
-            => InvokePSCommand<PSObject>(psCommand, executionOptions, cancellationToken);
+        {
+            InvokePSCommand<PSObject>(psCommand, executionOptions, cancellationToken);
+        }
 
         public TResult InvokePSDelegate<TResult>(string representation, ExecutionOptions executionOptions, Func<PowerShell, CancellationToken, TResult> func, CancellationToken cancellationToken)
         {
@@ -662,7 +667,7 @@ private void DoOneRepl(CancellationToken cancellationToken)
         private string GetPrompt(CancellationToken cancellationToken)
         {
             var command = new PSCommand().AddCommand("prompt");
-            IReadOnlyList<string> results = InvokePSCommand<string>(command, PowerShellExecutionOptions.Default, cancellationToken);
+            IReadOnlyList<string> results = InvokePSCommand<string>(command, executionOptions: null, cancellationToken);
             string prompt = results.Count > 0 ? results[0] : DefaultPrompt;
 
             if (CurrentRunspace.RunspaceOrigin != RunspaceOrigin.Local)
@@ -846,7 +851,7 @@ private void OnPowerShellIdle(CancellationToken idleCancellationToken)
             // to force event processing
             if (runPipelineForEventProcessing)
             {
-                InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), PowerShellExecutionOptions.Default, CancellationToken.None);
+                InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), executionOptions: null, CancellationToken.None);
             }
         }
 
diff --git a/src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs b/src/PowerShellEditorServices/Services/PowerShell/Utility/CommandHelpers.cs
@@ -183,7 +183,7 @@ public static async Task<string> GetCommandSynopsisAsync(
 
             IEnumerable<CommandInfo> aliases = await executionService.ExecuteDelegateAsync<IEnumerable<CommandInfo>>(
                 nameof(GetAliasesAsync),
-                Execution.ExecutionOptions.Default,
+                executionOptions: null,
                 (pwsh, _) =>
                 {
                     CommandInvocationIntrinsics invokeCommand = pwsh.Runspace.SessionStateProxy.InvokeCommand;
diff --git a/src/PowerShellEditorServices/Services/Workspace/RemoteFileManagerService.cs b/src/PowerShellEditorServices/Services/Workspace/RemoteFileManagerService.cs
@@ -657,8 +657,8 @@ private async void HandlePSEventReceivedAsync(object sender, PSEventArgs args)
         private Task RegisterPSEditFunctionAsync()
             => _executionService.ExecuteDelegateAsync(
                 "Register psedit function",
-                ExecutionOptions.Default,
-                (pwsh, cancellationToken) => RegisterPSEditFunction(pwsh.Runspace),
+                executionOptions: null,
+                (pwsh, _) => RegisterPSEditFunction(pwsh.Runspace),
                 CancellationToken.None);
 
         private void RegisterPSEditFunction(Runspace runspace)

Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ internal Task InitializeAsync()`
`107`	`107`	`// Register the editor object in the runspace`
`108`	`108`	`return ExecutionService.ExecuteDelegateAsync(`
`109`	`109`	`$"Create ${PSEditorVariableName} object",`
`110`		`- ExecutionOptions.Default,`
	`110`	`+ executionOptions: null,`
`111`	`111`	`(pwsh, _) => pwsh.Runspace.SessionStateProxy.PSVariable.Set(psEditor),`
`112`	`112`	`CancellationToken.None);`
`113`	`113`	`}`
Original file line number	Diff line number	Diff line change
`@@ -164,7 +164,7 @@ public static Task<DscBreakpointCapability> GetDscCapabilityAsync(`
`164`	`164`
`165`	`165`	`return psesHost.ExecuteDelegateAsync<DscBreakpointCapability>(`
`166`	`166`	`nameof(getDscBreakpointCapabilityFunc),`
`167`		`- ExecutionOptions.Default,`
	`167`	`+ executionOptions: null,`
`168`	`168`	`getDscBreakpointCapabilityFunc,`
`169`	`169`	`cancellationToken);`
`170`	`170`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ public SynchronousDelegateTask(`
`23`	`23`	`CancellationToken cancellationToken)`
`24`	`24`	`: base(logger, cancellationToken)`
`25`	`25`	`{`
`26`		`- ExecutionOptions = executionOptions;`
	`26`	`+ ExecutionOptions = executionOptions ?? new ExecutionOptions();`
`27`	`27`	`_representation = representation;`
`28`	`28`	`_action = action;`
`29`	`29`	`}`
`@@ -58,7 +58,7 @@ public SynchronousDelegateTask(`
`58`	`58`	`{`
`59`	`59`	`_func = func;`
`60`	`60`	`_representation = representation;`
`61`		`- ExecutionOptions = executionOptions;`
	`61`	`+ ExecutionOptions = executionOptions ?? new ExecutionOptions();`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`public override ExecutionOptions ExecutionOptions { get; }`
`@@ -94,7 +94,7 @@ public SynchronousPSDelegateTask(`
`94`	`94`	`_psesHost = psesHost;`
`95`	`95`	`_action = action;`
`96`	`96`	`_representation = representation;`
`97`		`- ExecutionOptions = executionOptions;`
	`97`	`+ ExecutionOptions = executionOptions ?? new ExecutionOptions();`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`public override ExecutionOptions ExecutionOptions { get; }`
`@@ -131,7 +131,7 @@ public SynchronousPSDelegateTask(`
`131`	`131`	`_psesHost = psesHost;`
`132`	`132`	`_func = func;`
`133`	`133`	`_representation = representation;`
`134`		`- ExecutionOptions = executionOptions;`
	`134`	`+ ExecutionOptions = executionOptions ?? new ExecutionOptions();`
`135`	`135`	`}`
`136`	`136`
`137`	`137`	`public override ExecutionOptions ExecutionOptions { get; }`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public SynchronousPowerShellTask(`
`36`	`36`	`_logger = logger;`
`37`	`37`	`_psesHost = psesHost;`
`38`	`38`	`_psCommand = command;`
`39`		`- PowerShellExecutionOptions = executionOptions;`
	`39`	`+ PowerShellExecutionOptions = executionOptions ?? new PowerShellExecutionOptions();`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`public PowerShellExecutionOptions PowerShellExecutionOptions { get; }`
Original file line number	Diff line number	Diff line change
`@@ -307,7 +307,8 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(`
`307`	`307`	`Func<PowerShell, CancellationToken, TResult> func,`
`308`	`308`	`CancellationToken cancellationToken)`
`309`	`309`	`{`
`310`		`- return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));`
	`310`	`+ return InvokeTaskOnPipelineThreadAsync(`
	`311`	`+ new SynchronousPSDelegateTask<TResult>(_logger, this, representation, executionOptions, func, cancellationToken));`
`311`	`312`	`}`
`312`	`313`
`313`	`314`	`public Task ExecuteDelegateAsync(`
`@@ -316,7 +317,8 @@ public Task ExecuteDelegateAsync(`
`316`	`317`	`Action<PowerShell, CancellationToken> action,`
`317`	`318`	`CancellationToken cancellationToken)`
`318`	`319`	`{`
`319`		`- return InvokeTaskOnPipelineThreadAsync(new SynchronousPSDelegateTask(_logger, this, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));`
	`320`	`+ return InvokeTaskOnPipelineThreadAsync(`
	`321`	`+ new SynchronousPSDelegateTask(_logger, this, representation, executionOptions, action, cancellationToken));`
`320`	`322`	`}`
`321`	`323`
`322`	`324`	`public Task<TResult> ExecuteDelegateAsync<TResult>(`
`@@ -325,7 +327,8 @@ public Task<TResult> ExecuteDelegateAsync<TResult>(`
`325`	`327`	`Func<CancellationToken, TResult> func,`
`326`	`328`	`CancellationToken cancellationToken)`
`327`	`329`	`{`
`328`		`- return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions ?? ExecutionOptions.Default, func, cancellationToken));`
	`330`	`+ return InvokeTaskOnPipelineThreadAsync(`
	`331`	`+ new SynchronousDelegateTask<TResult>(_logger, representation, executionOptions, func, cancellationToken));`
`329`	`332`	`}`
`330`	`333`
`331`	`334`	`public Task ExecuteDelegateAsync(`
`@@ -334,26 +337,26 @@ public Task ExecuteDelegateAsync(`
`334`	`337`	`Action<CancellationToken> action,`
`335`	`338`	`CancellationToken cancellationToken)`
`336`	`339`	`{`
`337`		`- return InvokeTaskOnPipelineThreadAsync(new SynchronousDelegateTask(_logger, representation, executionOptions ?? ExecutionOptions.Default, action, cancellationToken));`
	`340`	`+ return InvokeTaskOnPipelineThreadAsync(`
	`341`	`+ new SynchronousDelegateTask(_logger, representation, executionOptions, action, cancellationToken));`
`338`	`342`	`}`
`339`	`343`
`340`	`344`	`public Task<IReadOnlyList<TResult>> ExecutePSCommandAsync<TResult>(`
`341`	`345`	`PSCommand psCommand,`
`342`	`346`	`CancellationToken cancellationToken,`
`343`	`347`	`PowerShellExecutionOptions executionOptions = null)`
`344`	`348`	`{`
`345`		`- return InvokeTaskOnPipelineThreadAsync(new SynchronousPowerShellTask<TResult>(`
`346`		`- _logger,`
`347`		`- this,`
`348`		`- psCommand,`
`349`		`- executionOptions ?? PowerShellExecutionOptions.Default,`
`350`		`- cancellationToken));`
	`349`	`+ return InvokeTaskOnPipelineThreadAsync(`
	`350`	`+ new SynchronousPowerShellTask<TResult>(_logger, this, psCommand, executionOptions, cancellationToken));`
`351`	`351`	`}`
`352`	`352`
`353`	`353`	`public Task ExecutePSCommandAsync(`
`354`	`354`	`PSCommand psCommand,`
`355`	`355`	`CancellationToken cancellationToken,`
`356`		`- PowerShellExecutionOptions executionOptions = null) => ExecutePSCommandAsync<PSObject>(psCommand, cancellationToken, executionOptions);`
	`356`	`+ PowerShellExecutionOptions executionOptions = null)`
	`357`	`+ {`
	`358`	`+ return ExecutePSCommandAsync<PSObject>(psCommand, cancellationToken, executionOptions);`
	`359`	`+ }`
`357`	`360`
`358`	`361`	`public TResult InvokeDelegate<TResult>(string representation, ExecutionOptions executionOptions, Func<CancellationToken, TResult> func, CancellationToken cancellationToken)`
`359`	`362`	`{`
`@@ -374,7 +377,9 @@ public IReadOnlyList<TResult> InvokePSCommand<TResult>(PSCommand psCommand, Powe`
`374`	`377`	`}`
`375`	`378`
`376`	`379`	`public void InvokePSCommand(PSCommand psCommand, PowerShellExecutionOptions executionOptions, CancellationToken cancellationToken)`
`377`		`- => InvokePSCommand<PSObject>(psCommand, executionOptions, cancellationToken);`
	`380`	`+ {`
	`381`	`+ InvokePSCommand<PSObject>(psCommand, executionOptions, cancellationToken);`
	`382`	`+ }`
`378`	`383`
`379`	`384`	`public TResult InvokePSDelegate<TResult>(string representation, ExecutionOptions executionOptions, Func<PowerShell, CancellationToken, TResult> func, CancellationToken cancellationToken)`
`380`	`385`	`{`
`@@ -662,7 +667,7 @@ private void DoOneRepl(CancellationToken cancellationToken)`
`662`	`667`	`private string GetPrompt(CancellationToken cancellationToken)`
`663`	`668`	`{`
`664`	`669`	`var command = new PSCommand().AddCommand("prompt");`
`665`		`- IReadOnlyList<string> results = InvokePSCommand<string>(command, PowerShellExecutionOptions.Default, cancellationToken);`
	`670`	`+ IReadOnlyList<string> results = InvokePSCommand<string>(command, executionOptions: null, cancellationToken);`
`666`	`671`	`string prompt = results.Count > 0 ? results[0] : DefaultPrompt;`
`667`	`672`
`668`	`673`	`if (CurrentRunspace.RunspaceOrigin != RunspaceOrigin.Local)`
`@@ -846,7 +851,7 @@ private void OnPowerShellIdle(CancellationToken idleCancellationToken)`
`846`	`851`	`// to force event processing`
`847`	`852`	`if (runPipelineForEventProcessing)`
`848`	`853`	`{`
`849`		`- InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), PowerShellExecutionOptions.Default, CancellationToken.None);`
	`854`	`+ InvokePSCommand(new PSCommand().AddScript("0", useLocalScope: true), executionOptions: null, CancellationToken.None);`
`850`	`855`	`}`
`851`	`856`	`}`
`852`	`857`
Original file line number	Diff line number	Diff line change
`@@ -183,7 +183,7 @@ public static async Task<string> GetCommandSynopsisAsync(`
`183`	`183`
`184`	`184`	`IEnumerable<CommandInfo> aliases = await executionService.ExecuteDelegateAsync<IEnumerable<CommandInfo>>(`
`185`	`185`	`nameof(GetAliasesAsync),`
`186`		`- Execution.ExecutionOptions.Default,`
	`186`	`+ executionOptions: null,`
`187`	`187`	`(pwsh, _) =>`
`188`	`188`	`{`
`189`	`189`	`CommandInvocationIntrinsics invokeCommand = pwsh.Runspace.SessionStateProxy.InvokeCommand;`