-
Notifications
You must be signed in to change notification settings - Fork 409
Update docs and diagnostic message for UseCorrectCasing #2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs and diagnostic message for UseCorrectCasing #2138
Conversation
…l sites It made it cumbersome to pass a different number of arguments to the string.Format call and didn't seem necessary
…ameters, and operators
|
|
||
| ## How | ||
|
|
||
| - Use exact casing for type names. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see anything in the rule which acts on type names
sdwheeler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs changes look good to me.
bergmeister
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, will go through your other PRs the next days. Sorry it's taken so long
andyleejordan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
PR Summary
Fixes a small regression from #1704 where incorrectly cased parameters are reported as Functions/Cmdlets. i.e.
Resulted in a diagnostic message of:
Function/Cmdlet '-name' does not match its exact casing 'Name'.instead of:
Parameter '-name' of function/cmdlet 'Get-Process' does not match its exact casing 'Name'.Added some tests for the messages.
Small tweaks to rule docs too, including that the descriptions of
CheckCommandsandCheckOperatorwere transposed.Closes #2136
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.