Add checks for XPath for AvoidUsingInternalURL

Author: yutingc

Rules/AvoidUsingInternalURLs.cs

@@ -44,6 +44,27 @@ public IEnumerable<DiagnosticRecord> AnalyzeScript(Ast ast, string fileName)
             {
                 foreach (StringConstantExpressionAst expressionAst in expressionAsts)
                 {
+                    //Check if XPath is used. If XPath is used, then we don't throw warnings.
+                    Ast parentAst = expressionAst.Parent;
+                    IEnumerable<Ast> invocation = parentAst.FindAll(test => test is InvokeMemberExpressionAst, true);
+                    bool hasXPath = false;
+                    if (invocation != null)
+                    {
+                        foreach (InvokeMemberExpressionAst ieAst in invocation)
+                        {
+                            if (String.Equals(ieAst.Member.ToString(), "SelectSingleNode",StringComparison.OrdinalIgnoreCase) ||
+                                String.Equals(ieAst.Member.ToString(), "SelectNodes",StringComparison.OrdinalIgnoreCase))
+                            {
+                                hasXPath = true;
+                                break;
+                            }
+                        }
+                    }
+                    if (hasXPath)
+                    {
+                        continue;
+                    }
+                    
                     bool isPathValid = false;
                     bool isInternalURL = false;
                     //make sure there is no path 

Tests/Rules/AvoidUsingInternalURLs.ps1

@@ -3,4 +3,4 @@ $internalSite = "//msw"
 $externalSite = "http:\\msw"
 if (-not $scratch.EndsWith("/")) {
 	$scratch += "/";
-}
+}

Tests/Rules/AvoidUsingInternalURLsNoViolations.ps1

@@ -1,4 +1,8 @@
 $correctPath = "www.bing.com"
 $externalSite = "//outside.co/test"
 rmdir /s /q ".\Directory"
+function Test
+{
+	$filesNode = $infoXml.SelectSingleNode("//files")
+}
 $sd = "O:BAG:BAD:(A;;0x800;;;WD)(A;;0x120fff;;;SY)(A;;0x120fff;;;LS)(A;;0x120fff;;;NS)(A;;0x120fff;;;BA)(A;;0xee5;;;LU)(A;;LC;;;MU)(A;;0x800;;;AG)"