Change remaining warning to error

Author: Quoc Truong

Engine/ScriptAnalyzer.cs

@@ -281,10 +281,10 @@ internal bool ParseProfile(string profile, PathIntrinsics path, IOutputWriter wr
                                     excludeRuleList = excludeRuleList.Union(rhsList);
                                     break;
                                 default:
-                                    // keep writing warning here, we only stop processing if existing keys are wrong
-                                    writer.WriteWarning(
-                                        string.Format(CultureInfo.CurrentCulture, Strings.WrongKey, key,
-                                            kvp.Item1.Extent.StartLineNumber, kvp.Item1.Extent.StartColumnNumber, profile));
+                                    writer.WriteError(new ErrorRecord(
+                                        new InvalidDataException(string.Format(CultureInfo.CurrentCulture, Strings.WrongKey, key, kvp.Item1.Extent.StartLineNumber, kvp.Item1.Extent.StartColumnNumber, profile)),
+                                        Strings.WrongConfigurationKey, ErrorCategory.InvalidData, profile));
+                                    hasError = true;
                                     break;
                             }
                         }

Engine/Strings.Designer.cs

@@ -193,7 +193,7 @@
     <value>Cannot find any DiagnosticRecord with the Rule Suppression ID {0}.</value>
   </data>
   <data name="WrongKey" xml:space="preserve">
-    <value>{0} is not a valid key in the profile hashtable: line {1} column {2} in file {3}. This key value pair will not be processed.</value>
+    <value>{0} is not a valid key in the profile hashtable: line {1} column {2} in file {3}. Valid keys are ExcludeRules, IncludeRules and Severity.</value>
   </data>
   <data name="WrongKeyFormat" xml:space="preserve">
     <value>Key in the profile hashtable should be a string: line {0} column {1} in file {2}</value>
@@ -231,4 +231,7 @@
   <data name="ConfigurationValueWrongFormat" xml:space="preserve">
     <value>ConfigurationValueWrongFormat</value>
   </data>
+  <data name="WrongConfigurationKey" xml:space="preserve">
+    <value>WrongConfigurationKey</value>
+  </data>
 </root>

Engine/Strings.resx

@@ -77,7 +77,7 @@ Describe "GlobalSuppression" {
         It "Raises Error for wrong profile" {
             $invokeWithError = Invoke-ScriptAnalyzer "$directory\GlobalSuppression.ps1" -Configuration "$directory\WrongProfile.ps1" -ErrorAction SilentlyContinue
             $invokeWithError.Count | should be 0
-            $Error[0].FullyQualifiedErrorId | should match "ConfigurationValueWrongFormat,Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands.InvokeScriptAnalyzerCommand"
+            $Error[0].FullyQualifiedErrorId | should match "WrongConfigurationKey,Microsoft.Windows.PowerShell.ScriptAnalyzer.Commands.InvokeScriptAnalyzerCommand"
         }
     }
 }