Fix FunctionInfo fallback AST attribute analysis for UseShouldProcessCorrectly (#1659)

hubuk · web-flow · commit 158812bd342c · 2021-04-23T10:50:35.000-07:00
diff --git a/Rules/UseShouldProcessCorrectly.cs b/Rules/UseShouldProcessCorrectly.cs
@@ -350,7 +350,7 @@ private bool SupportsShouldProcess(string cmdName)
         private bool TryGetShouldProcessValueFromAst(FunctionInfo functionInfo, out bool hasShouldProcessSet)
         {
             // Get the body of the function
-            ScriptBlockAst functionBodyAst = (ScriptBlockAst)functionInfo.ScriptBlock.Ast.Find(ast => ast is ScriptBlockAst, searchNestedScriptBlocks: false);
+            ScriptBlockAst functionBodyAst = (ScriptBlockAst)functionInfo.ScriptBlock.Ast.Find(ast => ast is ScriptBlockAst, searchNestedScriptBlocks: true);
 
             // Go through attributes on the parameter block, since this is where [CmdletBinding()] will be
             foreach (AttributeAst attributeAst in functionBodyAst.ParamBlock.Attributes)

Original file line number	Diff line number	Diff line change
`@@ -350,7 +350,7 @@ private bool SupportsShouldProcess(string cmdName)`
`350`	`350`	`private bool TryGetShouldProcessValueFromAst(FunctionInfo functionInfo, out bool hasShouldProcessSet)`
`351`	`351`	`{`
`352`	`352`	`// Get the body of the function`
`353`		`- ScriptBlockAst functionBodyAst = (ScriptBlockAst)functionInfo.ScriptBlock.Ast.Find(ast => ast is ScriptBlockAst, searchNestedScriptBlocks: false);`
	`353`	`+ ScriptBlockAst functionBodyAst = (ScriptBlockAst)functionInfo.ScriptBlock.Ast.Find(ast => ast is ScriptBlockAst, searchNestedScriptBlocks: true);`
`354`	`354`
`355`	`355`	`// Go through attributes on the parameter block, since this is where [CmdletBinding()] will be`
`356`	`356`	`foreach (AttributeAst attributeAst in functionBodyAst.ParamBlock.Attributes)`