-
Notifications
You must be signed in to change notification settings - Fork 51
Description
Steps to reproduce
- Create a server
- Find a terra:overworld/overworld/pale_garden
- Walk around the pale forest
Expected behavior
Loading the biome should not cause massive TPS drop.
Actual behavior
Looks like a ton of leaves generated immediately decay as soon as the biome is loaded, which causes a ton of block updates which in turn, also causes lag.
Here's a spark report for reference. In this case, I did the test with clean server only with Terra and ViaVersion, so lag spikes are short but huge, so the background profiler is unable to fully pick it up.
This spike is much more noticeable if there're plugins that listen to block updates. First-hand experience using GriefDefender, although should apply to WorldGuard, Lands, GriefPrevention, anything that listens to block updates as mentioned, turning those mspt spikes into a full massive tps drop.
Background profiler while visiting a pale garden:
https://spark.lucko.me/Ab5e7nmqCu
Profiler with --only-ticks-over 30 flag:
https://spark.lucko.me/Q2LkD7wsFa