Use setpv not catpv

khwilliamson · Leont · commit fd2d97d3f944 · 2020-07-31T21:01:55.000+02:00
For extremely large version numbers, an undefined SV is appended to. See https://rt.perl.org/Ticket/Display.html?id=128207. The changes to non-vutil.c have long been in blead.
diff --git a/vutil/vutil.c b/vutil/vutil.c
@@ -693,7 +693,7 @@ Perl_upg_version(pTHX_ SV *ver, bool qv)
 #endif
 
 	if (sv) {
-                Perl_sv_catpvf(aTHX_ sv, "%.9" NVff, SvNVX(ver));
+                Perl_sv_setpvf(aTHX_ sv, "%.9" NVff, SvNVX(ver));
 	    len = SvCUR(sv);
 	    buf = SvPVX(sv);
 	}

Original file line number	Diff line number	Diff line change
`@@ -693,7 +693,7 @@ Perl_upg_version(pTHX_ SV *ver, bool qv)`
`693`	`693`	`#endif`
`694`	`694`
`695`	`695`	`if (sv) {`
`696`		`- Perl_sv_catpvf(aTHX_ sv, "%.9" NVff, SvNVX(ver));`
	`696`	`+ Perl_sv_setpvf(aTHX_ sv, "%.9" NVff, SvNVX(ver));`
`697`	`697`	`len = SvCUR(sv);`
`698`	`698`	`buf = SvPVX(sv);`
`699`	`699`	`}`