deprecation.t: Comment out tests

We're superseding a warning about the impending fatalization of
goto-label-jump with an exception.  Hence the deprecation warning no
longer needs to be tested in t/porting/deprecation.t.

However, we may (or may not) have been using that particular warning as
corpur for *other* tests of deprecation warnings.  For the time being,
we'll comment out 3 test blocks and mark them as TODO.

Author: jkeenan

t/porting/deprecation.t

@@ -90,56 +90,61 @@ if (-e ".git") {
         "There should not be any new files which mention WARN_DEPRECATED");
 }
 
-# Test that deprecation warnings are produced under "use warnings"
-# (set above)
-{
-    my $warning = "nada";
-    local $SIG{__WARN__} = sub { $warning = $_[0] };
-    my $count = 0;
-    while ($count<1) {
-        LABEL: $count++;
-        goto DONE if $count>1;
-    }
-    goto LABEL;
-    DONE:
-    like($warning,
-        qr/Use of "goto" to jump into a construct is deprecated, and will become fatal in Perl 5\.42/,
-        "Got expected deprecation warning");
-}
-# Test that we can silence deprecation warnings with "no warnings 'deprecated'"
-# as we used to.
-{
-    no warnings 'deprecated';
-    my $warning = "nada";
-    local $SIG{__WARN__} = sub { $warning = $_[0] };
-    my $count = 0;
-    while ($count<1) {
-        LABEL: $count++;
-        goto DONE if $count>1;
-    }
-    goto LABEL;
-    DONE:
-    like($warning, qr/nada/,
-        "no warnings 'deprecated'; silenced deprecation warning as expected");
-}
+# TODO: We don't need the 3 following test blocks for "Use of goto to jump
+# into a construct is deprecated" anymore ... but we may have been using these
+# blocks to test deprecation warnings more generally.  Hence, comment them out
+# for now (so that 'make test_porting' passes) and investigate further later.
+#
+## Test that deprecation warnings are produced under "use warnings"
+## (set above)
+#{
+#    my $warning = "nada";
+#    local $SIG{__WARN__} = sub { $warning = $_[0] };
+#    my $count = 0;
+#    while ($count<1) {
+#        LABEL: $count++;
+#        goto DONE if $count>1;
+#    }
+#    goto LABEL;
+#    DONE:
+#    like($warning,
+#        qr/Use of "goto" to jump into a construct is deprecated, and will become fatal in Perl 5\.42/,
+#        "Got expected deprecation warning");
+#}
+## Test that we can silence deprecation warnings with "no warnings 'deprecated'"
+## as we used to.
+#{
+#    no warnings 'deprecated';
+#    my $warning = "nada";
+#    local $SIG{__WARN__} = sub { $warning = $_[0] };
+#    my $count = 0;
+#    while ($count<1) {
+#        LABEL: $count++;
+#        goto DONE if $count>1;
+#    }
+#    goto LABEL;
+#    DONE:
+#    like($warning, qr/nada/,
+#        "no warnings 'deprecated'; silenced deprecation warning as expected");
+#}
 
-# Test that we can silence a specific deprecation warnings with "no warnings 'deprecated::$subcategory'"
-# and that by doing so we don't silence any other deprecation warnings.
-{
-    no warnings 'deprecated::goto_construct';
-    my $warning = "nada";
-    local $SIG{__WARN__} = sub { $warning = $_[0] };
-    my $count = 0;
-    while ($count<1) {
-        LABEL: $count++;
-        goto DONE if $count>1;
-    }
-    goto LABEL;
-    DONE:
-    like($warning, qr/nada/,
-        "no warnings 'deprecated::goto_construct'; silenced deprecation warning as expected");
-    @INC = ();
-    do "regen.pl"; # this should produce a deprecation warning
-    like($warning, qr/is no longer in \@INC/,
-        "no warnings 'deprecated::goto_construct'; did not silence deprecated::dot_in_inc warnings");
-}
+## Test that we can silence a specific deprecation warnings with "no warnings 'deprecated::$subcategory'"
+## and that by doing so we don't silence any other deprecation warnings.
+#{
+#    no warnings 'deprecated::goto_construct';
+#    my $warning = "nada";
+#    local $SIG{__WARN__} = sub { $warning = $_[0] };
+#    my $count = 0;
+#    while ($count<1) {
+#        LABEL: $count++;
+#        goto DONE if $count>1;
+#    }
+#    goto LABEL;
+#    DONE:
+#    like($warning, qr/nada/,
+#        "no warnings 'deprecated::goto_construct'; silenced deprecation warning as expected");
+#    @INC = ();
+#    do "regen.pl"; # this should produce a deprecation warning
+#    like($warning, qr/is no longer in \@INC/,
+#        "no warnings 'deprecated::goto_construct'; did not silence deprecated::dot_in_inc warnings");
+#}