sv_numcmp_common: only call magic once if the SVs are the same

tonycoz · tonycoz · commit 8a82284ae6af · 2025-12-03T15:03:35.000+11:00
similar to try_amagic_bin()
diff --git a/sv.c b/sv.c
@@ -8717,7 +8717,7 @@ S_sv_numcmp_common(pTHX_ SV **sv1, SV **sv2, const U32 flags,
     if(flags & SV_GMAGIC) {
         if(*sv1)
             SvGETMAGIC(*sv1);
-        if(*sv2)
+        if(*sv2 && (!*sv1 || *sv1 != *sv2))
             SvGETMAGIC(*sv2);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -8717,7 +8717,7 @@ S_sv_numcmp_common(pTHX_ SV sv1, SV sv2, const U32 flags,`
`8717`	`8717`	`if(flags & SV_GMAGIC) {`
`8718`	`8718`	`if(*sv1)`
`8719`	`8719`	`SvGETMAGIC(*sv1);`
`8720`		`- if(*sv2)`
	`8720`	`+ if(sv2 && (!sv1 \|\| sv1 != sv2))`
`8721`	`8721`	`SvGETMAGIC(*sv2);`
`8722`	`8722`	`}`
`8723`	`8723`