ParseXS: standard_typemap_locations(): skip -e

standard_typemap_locations() returns a set of filenames for where a
typemap file map be expected, relative to both the current directory and
to @inc.

The @inc files are filtered using -e, but the others (../../typemap etc)
aren't.

This commit removes the -e filtering for @inc, for consistency.
This means that standard_typemap_locations() now returns a list of
filenames of *all* the standard locations where a typemap file *might*
be found, regardless of whether the file exists. Previously it was a
weird hybrid.

This commit should make no difference in practice, since the one caller
of this function, process_typemaps() does it's own -f filtering too.

So really the net effect of this commit is to remove a few duplicate
stat() OS calls.

It also allows one existing test to be simplified, since now there will
always be one returned entry per @inc entry, whereas before it might
have been less.

Author: iabyn

dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm

@@ -147,7 +147,7 @@ SCOPE: {
     my @tm = @tm_template;
     foreach my $dir (@{ $include_ref}) {
       my $file = File::Spec->catfile($dir, ExtUtils => 'typemap');
-      unshift @tm, $file if -e $file;
+      unshift @tm, $file;
     }
     return @tm;
   }

dist/ExtUtils-ParseXS/t/101-standard_typemap_locations.t

@@ -17,17 +17,8 @@ use ExtUtils::ParseXS::Utilities qw(
         1
         unless @stl > 9;
 
-        # We check only as many location entries from the start of the array
-        # (where the @INC-related entries are) as there are entries from @INC.
-        # We manage to do that by stopping when we find the "updir" related
-        # entries, which we assume is never contained in a default @INC entry.
-        my $updir = File::Spec->updir;
+        # Check that at least one typemap file can be found under @INC
         my $max = $#INC;
-        $max = $#stl if $#stl < $max;
-        foreach my $i (0.. $max) {
-          $max = $i, last if $stl[$i] =~ /\Q$updir\E/;
-        }
-
         ok(
             ( 0 < (grep -f $_, @stl[0..$max]) ),
             "At least one typemap file exists underneath \@INC directories"
@@ -39,6 +30,7 @@ use ExtUtils::ParseXS::Utilities qw(
     my @fake_INC = qw(a/b/c  d/e/f  /g/h/i);
     my @expected =
         (
+            map("$_/ExtUtils/typemap", reverse @fake_INC),
             qw(
                 ../../../../lib/ExtUtils/typemap
                 ../../../../typemap