S_parse_ident: Add assertion

khwilliamson · khwilliamson · commit 087dc7fbe7f9 · 2025-10-17T12:09:03.000-06:00
The source to parse must be in the buffer terminated at PL_bufend.  This
was not obvious to me; this assertion would have caught my error
earlier.
diff --git a/toke.c b/toke.c
@@ -10470,6 +10470,7 @@ S_parse_ident(pTHX_ char **s, char **d, char * const e, int allow_package,
                     bool is_utf8, bool check_dollar)
 {
     PERL_ARGS_ASSERT_PARSE_IDENT;
+    assert(*s <= PL_bufend);
 
     while (*s < PL_bufend) {
         if (*d >= e)

Original file line number	Diff line number	Diff line change
`@@ -10470,6 +10470,7 @@ S_parse_ident(pTHX_ char s, char d, char * const e, int allow_package,`
`10470`	`10470`	`bool is_utf8, bool check_dollar)`
`10471`	`10471`	`{`
`10472`	`10472`	`PERL_ARGS_ASSERT_PARSE_IDENT;`
	`10473`	`+ assert(*s <= PL_bufend);`
`10473`	`10474`
`10474`	`10475`	`while (*s < PL_bufend) {`
`10475`	`10476`	`if (*d >= e)`