More Dead Code

I sure wish Scrutinizer would give a complete report.

Author: oleibman

tests/PhpSpreadsheetTests/Worksheet/AutoFilter/ColumnTest.php

@@ -96,7 +96,7 @@ public function testVariousSets(): void
 
         $result = $columnFilter->setJoin(Column::AUTOFILTER_COLUMN_JOIN_AND);
 
-        $result = $columnFilter->getJoin();
+        $result = $result->getJoin();
         self::assertEquals(Column::AUTOFILTER_COLUMN_JOIN_AND, $result);
     }
 
@@ -174,10 +174,9 @@ public function testSetAttribute(): void
         ];
 
         foreach ($attributeSet as $attributeName => $attributeValue) {
-            //    Setters return the instance to implement the fluent interface
-            $result = $columnFilter->setAttribute($attributeName, $attributeValue);
+            $columnFilter->setAttribute($attributeName, $attributeValue);
         }
-        self::assertSame($attributeSet, $result->getAttributes());
+        self::assertSame($attributeSet, $columnFilter->getAttributes());
     }
 
     public function testGetAttribute(): void

tests/PhpSpreadsheetTests/Worksheet/Table/ColumnTest.php

@@ -67,11 +67,11 @@ public function testVariousSets(): void
 
         $label = 'Total';
         $result = $column->setTotalsRowLabel($label);
-        self::assertEquals($label, $column->getTotalsRowLabel());
+        self::assertEquals($label, $result->getTotalsRowLabel());
 
         $function = 'sum';
         $result = $column->setTotalsRowFunction($function);
-        self::assertEquals($function, $column->getTotalsRowFunction());
+        self::assertEquals($function, $result->getTotalsRowFunction());
 
         $formula = '=SUM(Sales_Data[[#This Row],[Q1]:[Q4]])';
         $result = $column->setColumnFormula($formula);

tests/PhpSpreadsheetTests/Worksheet/Table/TableStyleTest.php

@@ -19,16 +19,16 @@ public function testVariousSets(): void
         $result = $style->setTheme(TableStyle::TABLE_STYLE_DARK1);
         self::assertEquals(TableStyle::TABLE_STYLE_DARK1, $result->getTheme());
 
-        $result = $style->setShowFirstColumn(true);
+        $style->setShowFirstColumn(true);
         self::assertTrue($style->getShowFirstColumn());
 
-        $result = $style->setShowLastColumn(true);
+        $style->setShowLastColumn(true);
         self::assertTrue($style->getShowLastColumn());
 
-        $result = $style->setShowRowStripes(true);
+        $style->setShowRowStripes(true);
         self::assertTrue($style->getShowRowStripes());
 
-        $result = $style->setShowColumnStripes(true);
+        $style->setShowColumnStripes(true);
         self::assertTrue($style->getShowColumnStripes());
     }
 

tests/PhpSpreadsheetTests/Worksheet/Table/TableTest.php

@@ -116,7 +116,7 @@ public function testVariousSets(): void
         self::assertFalse($result->getShowHeaderRow());
 
         $result = $table->setShowTotalsRow(true);
-        self::assertTrue($table->getShowTotalsRow());
+        self::assertTrue($result->getShowTotalsRow());
     }
 
     public function testGetWorksheet(): void