From 4efe7c00f675d6aeccda487653d3b50cd07c8c0b Mon Sep 17 00:00:00 2001 From: 2-rust Date: Sat, 6 Dec 2025 09:37:50 -0500 Subject: [PATCH 1/2] Allow _pause() when already paused to prevent DOS --- contracts/utils/Pausable.sol | 7 +++---- fv/specs/Pausable.spec | 6 +++--- test/utils/Pausable.test.js | 6 ++++-- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/contracts/utils/Pausable.sol b/contracts/utils/Pausable.sol index 68e7d2681b4..6d7b33901d3 100644 --- a/contracts/utils/Pausable.sol +++ b/contracts/utils/Pausable.sol @@ -89,11 +89,10 @@ abstract contract Pausable is Context { /** * @dev Triggers stopped state. * - * Requirements: - * - * - The contract must not be paused. + * This function can be called even when the contract is already paused, which + * can be useful in emergency scenarios to prevent denial of service. */ - function _pause() internal virtual whenNotPaused { + function _pause() internal virtual { _paused = true; emit Paused(_msgSender()); } diff --git a/fv/specs/Pausable.spec b/fv/specs/Pausable.spec index a7aff9cc142..f93be09d349 100644 --- a/fv/specs/Pausable.spec +++ b/fv/specs/Pausable.spec @@ -23,11 +23,11 @@ rule pause(env e) { bool pausedAfter = paused(); - // liveness - assert success <=> !pausedBefore, "works if and only if the contract was not paused before"; + // liveness - pause() can be called even when already paused to prevent DOS + assert success, "pause() always succeeds, even when already paused"; // effect - assert success => pausedAfter, "contract must be paused after a successful call"; + assert pausedAfter, "contract must be paused after a successful call"; } /* diff --git a/test/utils/Pausable.test.js b/test/utils/Pausable.test.js index 67d74a0d88c..ece31a537f7 100644 --- a/test/utils/Pausable.test.js +++ b/test/utils/Pausable.test.js @@ -51,8 +51,10 @@ describe('Pausable', function () { expect(await this.mock.drasticMeasureTaken()).to.be.true; }); - it('reverts when re-pausing', async function () { - await expect(this.mock.pause()).to.be.revertedWithCustomError(this.mock, 'EnforcedPause'); + it('allows re-pausing when already paused', async function () { + const tx = await this.mock.pause(); + await expect(tx).to.emit(this.mock, 'Paused').withArgs(this.pauser); + expect(await this.mock.paused()).to.be.true; }); describe('unpausing', function () { From acbc7f7a4c277fb2c4e9f3a6148be9ebcba9ab68 Mon Sep 17 00:00:00 2001 From: 2-rust Date: Sat, 6 Dec 2025 11:27:40 -0500 Subject: [PATCH 2/2] Add changeset for allowing pause when already paused --- .changeset/smooth-penguins-pause.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 .changeset/smooth-penguins-pause.md diff --git a/.changeset/smooth-penguins-pause.md b/.changeset/smooth-penguins-pause.md new file mode 100644 index 00000000000..bd28c9211b1 --- /dev/null +++ b/.changeset/smooth-penguins-pause.md @@ -0,0 +1,6 @@ +--- +'openzeppelin-solidity': patch +--- + +Allow `_pause()` to be called when the contract is already paused, preventing denial of service in emergency scenarios. +