[BUG] Warmup feature completely breaks some gametypes

[The-Gig]

Hi, a guy pointed out to me a bug with Possession mode, as he reported to me that the score count didn't go up when someone was holding the flag. I wasn't able to reproduce his bug at first, but then he discovered it happened in case g_dowarmup was enabled.
So, now I can confirm the bug is there.

If you start a Possession match (g_gametype 13) in OAX with g_dowarmup 1, "waiting for players" text is displayed all the time even if there are some bots in the map and score remains at 0. Your g_warmup time does not seem to make any difference. If you set g_dowarmup back to 0 and then restart the map, "waiting for players" disappears and people can actually score.

Long story short: Possession doesn't work if warmup is enabled.

(Update: it also affects some other gametypes, see later messages.)

[NeonKnightOA]

There have been several new commits all this time. Does the bug still happen?

[The-Gig]

I just tried with oax from openarena_gamecode_2022-04-03_5a9476e.zip and the bug seems to still be there.

[NeonKnightOA]

I honestly don't know where the bug can be found. Summoning @sago007 .

[The-Gig]

UPDATE: I've noticed that Possession (13) is not the only gametype affected by the bug.
It also affects FFA (0) and Last Man Standing (10).
It even affects "Single Player" mode (gametype 2): although starting a Single Player match from the GUI automatically sets g_dowarmup 0, if you then enable warmup again, you get the problem.

So, in case you set g_dowarmup 1, it's impossible to play those gametypes, as "waiting for players" is always shown and the match never starts.
Tournament mode (1), despite being non-team-based, too, seems to be unaffected.

This is a post-0.8.8 bug, as it happens with current OAX (April 2022), but not with OA 0.8.8 gamecode.

[NeonKnightOA]

I need to know in which situation the bug is triggered and if it happens with these releases:

• Last nightly
• b53
• Last 2023 nightly
• b52
• First nightly
• 0.8.8

[The-Gig]

I just made a quick test with Nightly Build 2024-03-27_1c0587e.zip.
It looks like it doesn't happen anymore, it's possible the many under-the-hood changes happened recently also fixed this by coincidence.
However, let's wait before closing this issue, as I'd like to do some more testing about it next week.

[NeonKnightOA]

FWIW I've added the testing links.