moved more tests to verify

Author: david-driscoll

src/Protocol/Features/Document/CallHierarchyFeature.cs

@@ -112,8 +112,8 @@ public abstract record CallHierarchyBaseCallParams : ICanBeResolved
 
             JToken? ICanBeResolved.Data
             {
-                get => Item.GetRawData();
-                init => Item.SetRawData(value);
+                get => Item?.GetRawData();
+                init => Item?.SetRawData(value);
             }
         }
 
@@ -124,8 +124,8 @@ public abstract record CallHierarchyBaseCallParams<T> : ICanBeResolved
 
             JToken? ICanBeResolved.Data
             {
-                get => Item.GetRawData();
-                init => Item.SetRawData(value);
+                get => Item?.GetRawData();
+                init => Item?.SetRawData(value);
             }
         }
 

src/Protocol/Features/Document/DiagnosticsFeature.cs

@@ -121,13 +121,13 @@ public static RelatedDocumentDiagnosticReport From(RelatedDocumentDiagnosticRepo
 
             internal class Converter : JsonConverter<RelatedDocumentDiagnosticReport>
             {
-                public override void WriteJson(JsonWriter writer, RelatedDocumentDiagnosticReport value, JsonSerializer serializer)
+                public override void WriteJson(JsonWriter writer, RelatedDocumentDiagnosticReport? value, JsonSerializer serializer)
                 {
                     throw new NotImplementedException();
                 }
 
                 public override RelatedDocumentDiagnosticReport ReadJson(
-                    JsonReader reader, Type objectType, RelatedDocumentDiagnosticReport existingValue, bool hasExistingValue, JsonSerializer serializer
+                    JsonReader reader, Type objectType, RelatedDocumentDiagnosticReport? existingValue, bool hasExistingValue, JsonSerializer serializer
                 )
                 {
                     throw new NotImplementedException();

src/Protocol/Features/Document/InlineValueFeature.cs

@@ -63,7 +63,7 @@ public partial record InlineValueContext
             /// </summary>
             public Range StoppedLocation { get; set; }
         }
-        
+
         [Parallel]
         [Method(WorkspaceNames.InlineValueRefresh, Direction.ServerToClient)]
         [GenerateHandler("OmniSharp.Extensions.LanguageServer.Protocol.Workspace")]
@@ -94,22 +94,30 @@ public override InlineValueBase ReadJson(
                 )
                 {
                     var result = JObject.Load(reader);
-                    if (result["text"] is { Type: JTokenType.String })
+                    if (result.ContainsKey("text"))
                     {
-                        return result.ToObject<InlineValueText>();
+                        return new InlineValueText()
+                        {
+                            Range = result["range"]!.ToObject<Range?>()!,
+                            Text = result["text"]!.Value<string>()!
+                        };
                     }
 
-                    if (result["variableName"] is { Type: JTokenType.String })
+                    if (result.ContainsKey("variableName") || result.ContainsKey("caseSensitiveLookup"))
                     {
-                        return result.ToObject<InlineValueVariableLookup>();
+                        return new InlineValueVariableLookup()
+                        {
+                            Range = result["range"].ToObject<Range>()!,
+                            VariableName = result["variableName"]!.Value<string>()!,
+                            CaseSensitiveLookup = result["caseSensitiveLookup"]?.Value<bool?>() ?? false,
+                        };
                     }
 
-                    if (result["expression"] is { Type: JTokenType.String })
+                    return new InlineValueEvaluatableExpression()
                     {
-                        return result.ToObject<InlineValueEvaluatableExpression>();
-                    }
-
-                    return null!;
+                        Range = result["range"].ToObject<Range>()!,
+                        Expression = result["expression"]?.Value<string>()
+                    };
                 }
             }
         }
@@ -119,7 +127,6 @@ public override InlineValueBase ReadJson(
         ///
         /// @since 3.17.0
         /// </summary>
-        [JsonConverter(typeof(Converter))]
         public partial record InlineValueText : InlineValueBase
         {
             /// <summary>
@@ -138,7 +145,6 @@ public partial record InlineValueText : InlineValueBase
         ///
         /// @since 3.17.0
         /// </summary>
-        [JsonConverter(typeof(Converter))]
         public partial record InlineValueVariableLookup : InlineValueBase
         {
             /// <summary>
@@ -163,7 +169,6 @@ public partial record InlineValueVariableLookup : InlineValueBase
         ///
         /// @since 3.17.0
         /// </summary>
-        [JsonConverter(typeof(Converter))]
         public partial record InlineValueEvaluatableExpression : InlineValueBase
         {
             /// <summary>

src/Protocol/Features/Document/MonikerFeature.cs

@@ -23,7 +23,7 @@ namespace Models
         /// </summary>
         [Parallel]
         [Method(TextDocumentNames.Moniker, Direction.ClientToServer)]
-        [GenerateHandler("OmniSharp.Extensions.LanguageServer.Protocol.Document")]
+        [GenerateHandler("OmniSharp.Extensions.LanguageServer.Protocol.Document", Name = "Monikers")]
         [GenerateHandlerMethods]
         [GenerateRequestMethods(typeof(ITextDocumentLanguageClient), typeof(ILanguageClient))]
         [RegistrationOptions(typeof(MonikerRegistrationOptions))]