Apply remaining 3.17 updates.

Author: JoeRobich

.build/.build.csproj

@@ -11,7 +11,6 @@
     </PropertyGroup>
 
     <ItemGroup>
-        <PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" />
         <PackageReference Include="GitVersion.Tool" ExcludeAssets="All" />
         <PackageReference Include="ReportGenerator" ExcludeAssets="All" />
         <PackageReference Include="JetBrains.ReSharper.CommandLineTools" ExcludeAssets="All" />

language-server-protocol.sha.txt

@@ -1,5 +1,5 @@
 -- This is the last commit we caught up with https://github.com/Microsoft/language-server-protocol/commits/gh-pages
-lastSha: bdcc0f2
+lastSha: 5fc92456c046ed980646bb95c1d2e390d5b3ef9d
 
-https://github.com/Microsoft/language-server-protocol/compare/ed804013dc545b0e10bcb0a57d872c414bbc1f3c..gh-pages
+https://github.com/Microsoft/language-server-protocol/compare/5fc92456c046ed980646bb95c1d2e390d5b3ef9d..gh-pages
 

src/Protocol/Client/Capabilities/IWindowClientCapabilities.cs

@@ -3,7 +3,7 @@
     public interface IWindowClientCapabilities : ICapabilitiesBase
     {
         /// <summary>
-        /// Whether client supports handling progress notifications.
+        /// Whether the client supports server initiated progress using the `window/workDoneProgress/create` request.
         /// </summary>
         Supports<bool> WorkDoneProgress { get; set; }
 
@@ -21,4 +21,4 @@ public interface IWindowClientCapabilities : ICapabilitiesBase
         /// </summary>
         Supports<ShowDocumentClientCapabilities> ShowDocument { get; set; }
     }
-}
+}

src/Protocol/Client/Capabilities/WindowClientCapabilities.cs

@@ -6,7 +6,7 @@ namespace OmniSharp.Extensions.LanguageServer.Protocol.Client.Capabilities
     public class WindowClientCapabilities : CapabilitiesBase, IWindowClientCapabilities
     {
         /// <summary>
-        /// Whether client supports handling progress notifications.
+        /// Whether the client supports server initiated progress using the `window/workDoneProgress/create` request.
         /// </summary>
         public Supports<bool> WorkDoneProgress { get; set; }
 

src/Protocol/Features/Document/ColorFeature.cs

@@ -76,7 +76,7 @@ public partial record ColorPresentation
 
             /// <summary>
             /// An [edit](#TextEdit) which is applied to a document when selecting
-            /// this presentation for the color.  When `falsy` the [label](#ColorPresentation.label)
+            /// this presentation for the color.  When omitted the [label](#ColorPresentation.label)
             /// is used.
             /// </summary>
             [Optional]

src/Protocol/Features/Document/CompletionFeature.cs

@@ -113,22 +113,22 @@ public partial record CompletionItem : ICanBeResolved, IRequest<CompletionItem>,
 
             /// <summary>
             /// A string that shoud be used when comparing this item
-            /// with other items. When `falsy` the label is used.
+            /// with other items. When omitted the label is used.
             /// </summary>
             [Optional]
             public string? SortText { get; init; }
 
             /// <summary>
             /// A string that should be used when filtering a set of
-            /// completion items. When `falsy` the label is used.
+            /// completion items. When omitted the label is used.
             /// </summary>
 
             [Optional]
             public string? FilterText { get; init; }
 
             /// <summary>
             /// A string that should be inserted a document when selecting
-            /// this completion. When `falsy` the label is used.
+            /// this completion. When omitted the label is used.
             /// </summary>
 
             [Optional]
@@ -223,7 +223,7 @@ public partial record CompletionItem : ICanBeResolved, IRequest<CompletionItem>,
             [Optional]
             public JToken? Data { get; init; }
 
-            private string DebuggerDisplay => $"[{Kind}] {Label}{( Tags?.Any() == true ? $" tags: {string.Join(", ", Tags.Select(z => z.ToString()))}" : "" )}";
+            private string DebuggerDisplay => $"[{Kind}] {Label}{(Tags?.Any() == true ? $" tags: {string.Join(", ", Tags.Select(z => z.ToString()))}" : "")}";
 
             /// <inheritdoc />
             public override string ToString() => DebuggerDisplay;
@@ -351,7 +351,7 @@ public class CompletionRegistrationCompletionItemOptions
             /// details (see also `CompletionItemLabelDetails`) when receiving
             /// a completion item in a resolve call.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public bool? LabelDetailsSupport { get; set; }
@@ -438,7 +438,7 @@ public CompletionList(IEnumerable<CompletionItem> items, bool isIncomplete) : ba
             /// signals support for this via the `completionList.itemDefaults`
             /// capability.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public CompletionListItemDefaults? ItemDefaults { get; set; }
@@ -450,11 +450,11 @@ public CompletionList(IEnumerable<CompletionItem> items, bool isIncomplete) : ba
                     {
                         ItemDefaults = list.ItemDefaults
                     },
-                    _        => null
+                    _ => null
                 };
 
             public static CompletionList From(CompletionList? source, IEnumerable<CompletionItem>? result)
-                => new ((source?.Items ?? Array.Empty<CompletionItem>()).Concat(result ?? Array.Empty<CompletionItem>()))
+                => new((source?.Items ?? Array.Empty<CompletionItem>()).Concat(result ?? Array.Empty<CompletionItem>()))
                 {
                     ItemDefaults = source?.ItemDefaults
                 };
@@ -559,7 +559,7 @@ public CompletionList(bool isIncomplete, params CompletionItem<T>[] items) : bas
             /// signals support for this via the `completionList.itemDefaults`
             /// capability.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public CompletionListItemDefaults? ItemDefaults { get; set; }
@@ -574,71 +574,71 @@ public CompletionList(bool isIncomplete, params CompletionItem<T>[] items) : bas
                         },
                     _ => null
                 };
-            
+
             [return: System.Diagnostics.CodeAnalysis.NotNullIfNotNull("container")]
-            public static implicit operator CompletionList? (CompletionList<T>? container) => container switch
+            public static implicit operator CompletionList?(CompletionList<T>? container) => container switch
             {
                 not null => new CompletionList(container.Select(value => (CompletionItem)value), container.IsIncomplete)
                 {
                     ItemDefaults = container.ItemDefaults
                 },
-                _        => null
+                _ => null
             };
-            
+
         }
-        
-            internal class TypedCompletionListConverter : JsonConverter
-            {
-                public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
-                {
-                    serializer.Serialize(writer, (CompletionList?)value);
-                }
 
-                public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
-                {
-                    var completionList = serializer.Deserialize<CompletionList>(reader);
-                    return objectType.GetMethod(nameof(CompletionList<IHandlerIdentity>.Create), BindingFlags.Static | BindingFlags.Public)!
-                              .Invoke(null, new object[] { completionList })!;
-                }
+        internal class TypedCompletionListConverter : JsonConverter
+        {
+            public override void WriteJson(JsonWriter writer, object? value, JsonSerializer serializer)
+            {
+                serializer.Serialize(writer, (CompletionList?)value);
+            }
 
-                public override bool CanConvert(Type objectType)
-                {
-                    return objectType.IsGenericType && objectType.GetGenericTypeDefinition() == typeof(CompletionList<>);
-                }
+            public override object? ReadJson(JsonReader reader, Type objectType, object? existingValue, JsonSerializer serializer)
+            {
+                var completionList = serializer.Deserialize<CompletionList>(reader);
+                return objectType.GetMethod(nameof(CompletionList<IHandlerIdentity>.Create), BindingFlags.Static | BindingFlags.Public)!
+                          .Invoke(null, new object[] { completionList })!;
+            }
 
-                public override bool CanRead => true;
+            public override bool CanConvert(Type objectType)
+            {
+                return objectType.IsGenericType && objectType.GetGenericTypeDefinition() == typeof(CompletionList<>);
             }
 
+            public override bool CanRead => true;
+        }
+
         public record CompletionListItemDefaults
         {
             /// <summary>
             /// A default commit character set.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public Container<string>? CommitCharacters { get; init; }
 
             /// <summary>
             /// A default edit range
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public RangeOrEditRange? EditRange { get; init; }
 
             /// <summary>
             /// A default insert text format
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public InsertTextFormat? InsertTextFormat { get; init; }
 
             /// <summary>
             /// A default insert text mode
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             public InsertTextMode? InsertTextMode { get; init; }
 
@@ -704,7 +704,7 @@ public partial class CompletionCapability : DynamicCapability
             /// The client's default when the completion item doesn't provide a
             /// `insertTextMode` property.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public InsertTextMode? InsertTextMode { get; set; }
@@ -713,7 +713,7 @@ public partial class CompletionCapability : DynamicCapability
             /// The client supports the following `CompletionList` specific
             /// capabilities.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public CompletionListCapabilityOptions? CompletionList { get; set; }
@@ -723,19 +723,19 @@ public partial class CompletionCapability : DynamicCapability
         /// The client supports the following `CompletionList` specific
         /// capabilities.
         ///
-        /// @since 3.17.0 - proposed state
+        /// @since 3.17.0
         /// </summary>
         public class CompletionListCapabilityOptions
         {
             /// <summary>
-            /// The client supports the the following itemDefaults on
+            /// The client supports the following itemDefaults on
             /// a completion list.
             ///
             /// The value lists the supported property names of the
             /// `CompletionList.itemDefaults` object. If omitted
             /// no properties are supported.
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public Container<string>? ItemDefaults { get; set; }
@@ -832,7 +832,7 @@ public class CompletionItemCapabilityOptions
             /// The client has support for completion item label
             /// details (see also `CompletionItemLabelDetails`).
             ///
-            /// @since 3.17.0 - proposed state
+            /// @since 3.17.0
             /// </summary>
             [Optional]
             public bool LabelDetailsSupport { get; set; }

src/Protocol/Features/Document/DiagnosticsFeature.cs

@@ -508,7 +508,7 @@ public partial class DiagnosticClientCapabilities : DynamicCapability
         /// Capabilities specific to the code lens requests scoped to the
         /// workspace.
         ///
-        /// @since 3.16.0.
+        /// @since 3.17.0.
         /// </summary>
         [CapabilityKey(nameof(ClientCapabilities.Workspace), nameof(WorkspaceClientCapabilities.Diagnostics))]
         public class DiagnosticWorkspaceClientCapabilities : ICapability

src/Protocol/Features/Document/DocumentLinkFeature.cs

@@ -32,7 +32,7 @@ public partial record DocumentLinkParams : ITextDocumentIdentifierParams, IParti
             /// </summary>
             public TextDocumentIdentifier TextDocument { get; init; } = null!;
         }
-        
+
         public partial class DocumentLinkContainer { }
 
         /// <summary>

src/Protocol/Features/Document/DocumentOnTypeFormattingFeature.cs

@@ -28,18 +28,23 @@ public partial record DocumentOnTypeFormattingParams : ITextDocumentIdentifierPa
             public TextDocumentIdentifier TextDocument { get; init; } = null!;
 
             /// <summary>
-            /// The position at which this request was sent.
+            /// The position around which the on type formatting should happen.
+            /// This is not necessarily the exact position where the character denoted
+            /// by the property `ch` got typed.
             /// </summary>
             public Position Position { get; init; } = null!;
 
             /// <summary>
-            /// The character that has been typed.
+            /// The character that has been typed that triggered the formatting
+            /// on type request.That is not necessarily the last character that
+            /// got inserted into the document since the client could auto insert
+            /// characters as well(e.g.like automatic brace completion).
             /// </summary>
             [JsonProperty("ch")]
             public string Character { get; init; } = null!;
 
             /// <summary>
-            /// The format options.
+            /// The formatting options.
             /// </summary>
             public FormattingOptions Options { get; init; } = null!;
         }
@@ -49,7 +54,7 @@ public partial record DocumentOnTypeFormattingParams : ITextDocumentIdentifierPa
         public partial class DocumentOnTypeFormattingRegistrationOptions : ITextDocumentRegistrationOptions, IWorkDoneProgressOptions
         {
             /// <summary>
-            /// A character on which formatting should be triggered, like `}`.
+            /// A character on which formatting should be triggered, like `{`.
             /// </summary>
             public string FirstTriggerCharacter { get; set; } = null!;
 

src/Protocol/Features/Document/InlayHintFeature.cs

@@ -128,8 +128,8 @@ public partial record InlayHint : ICanBeResolved, IRequest<InlayHint>, IDoesNotP
 
             private string DebuggerDisplay => ToString();
         }
-        
-        public partial class InlayHintContainer {}
+
+        public partial class InlayHintContainer { }
 
         /// <summary>
         /// An inlay hint label part allows for interactive and composite labels
@@ -251,7 +251,6 @@ public override StringOrInlayHintLabelParts ReadJson(
         ///
         /// @since 3.17.0
         /// </summary>
-        /// 
         [JsonConverter(typeof(NumberEnumConverter))]
         public enum InlayHintKind
         {
@@ -273,9 +272,7 @@ public partial class InlayHintRegistrationOptions : ITextDocumentRegistrationOpt
         {
             /// <summary>
             /// The server provides support to resolve additional
-            /// information for a code action.
-            ///
-            /// @since 3.16.0
+            /// information for an inlay hint item.
             /// </summary>
             [Optional]
             public bool ResolveProvider { get; set; }