Additional params in methods - create_vd

[ulmitov]

Hi,
Regarding controller.create_vd,

For raid1 and raid10 must specify PDperArray=2,
otherwise the add vd command will fail with:
"operation not possible for current RAID level, Cannot create configuration with 1 span".

Can you please add a parameter to this method so it can get some additional params to append to the add vd command ?
Probably the additional params will be needed in other methods also.

[ulmitov]

@ralequi @dojci Hi,
please tell me if issues in this project can be fixed

Thanks

[ralequi]

Hi @ulmitov . Absolutely forget about this issues.

Let me check if I can reproduce them and generate the corresponding tests & fixes

[ralequi]

Hi @ulmitov

Please, check develop branch and confirm this issue is fixed

[ulmitov]

posted a comment in the commit, add vd has many additional params

[ralequi]

First of all,
You can leave PDperArray to None

Notice that I've added this to the code:

        if raid == '1' or raid == '10':
            if PDperArray is None:
                PDperArray = 2

In other scenarios PDperArray is not required AFAIK.

I'll consider adding the other params you have suggested

[ulmitov]

for raid1 i've rechecked, don't need pdperarray.
for raid60 it should be 4
for raid00 should be 1

[ralequi]

• For raid0 it is not required:

{
"Controllers":[
{
        "Command Status" : {
                "CLI Version" : "007.1704.0000.0000 Jan 16, 2021",
                "Operating system" : "Linux 5.15.0-58-generic",
                "Controller" : 0,
                "Status" : "Success",
                "Description" : "Add VD Succeeded."
        }
}
]
}

• agree raid1 does not requires it
• for raid6 it is not required:

{
"Controllers":[
{
        "Command Status" : {
                "CLI Version" : "007.1704.0000.0000 Jan 16, 2021",
                "Operating system" : "Linux 5.15.0-58-generic",
                "Controller" : 0,
                "Status" : "Success",
                "Description" : "Add VD Succeeded."
        }
}
]
}

As far as I'm checking, it is not required for any raid that does not have an underlying raid

I think this code should work fine:

        if int(raid) >= 10 and PDperArray is None:
            # Try to count the number of drives in the array
            # The format of the drives argument is e:s|e:s-x|e:s-x,y;e:s-x,y,z
            # The number of drives is the number of commas plus the dashes intervals

            numDrives = 0
            drives2 = drives.split(':')
            drives2 = drives2[1]
            numDrives += drives2.count(',')+1
            for interval in drives2.split(','):
                if '-' in interval:
                    left = int(interval.split('-')[0])
                    right = int(interval.split('-')[1])
                    numDrives += right - left

            PDperArray = numDrives//2

        if raid == '00' and PDperArray is None:
            PDperArray = 1

I don't know what raid "00" stands for, but at least it is not documented on LSI's storcli doc: https://docs.broadcom.com/doc/12352476

[ulmitov]

for now i see it's required only for 00, 10, 60.
'00' is based on '0', some controllers have it:
"Capabilities" : {
"Supported Drives" : "SAS, SATA",
"RAID Level Supported" : "RAID0, RAID1(2 or more drives), RAID5, RAID6, RAID00, RAID10(2 or more drives per span), RAID50, RAID60",

[ralequi]

Do you think that fix would be enough or do you propose something else?