Skip to content

Commit e5eb032

Browse files
committed
fix: fix cloud deploy command
Currently `tns cloud deploy` command starts local build as the provided buildAction through deviceDescriptor is not executed from deployController.
1 parent 5c8d509 commit e5eb032

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

lib/controllers/deploy-controller.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
11
export class DeployController {
22

33
constructor(
4-
private $buildController: IBuildController,
54
private $deviceInstallAppService: IDeviceInstallAppService,
6-
private $devicesService: Mobile.IDevicesService
5+
private $devicesService: Mobile.IDevicesService,
6+
private $prepareController: IPrepareController
77
) { }
88

99
public async deploy(data: IDeployData): Promise<void> {
1010
const { buildData, deviceDescriptors } = data;
1111

1212
const executeAction = async (device: Mobile.IDevice) => {
13-
const packageFilePath = await this.$buildController.prepareAndBuild({ ...buildData, buildForDevice: !device.isEmulator });
13+
await this.$prepareController.prepare(buildData);
14+
const deviceDescriptor = _.find(deviceDescriptors, dd => dd.identifier === device.deviceInfo.identifier);
15+
const packageFilePath = await deviceDescriptor.buildAction();
1416
await this.$deviceInstallAppService.installOnDevice(device, { ...buildData, buildForDevice: !device.isEmulator }, packageFilePath);
1517
};
1618

lib/helpers/deploy-command-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ export class DeployCommandHelper {
3636

3737
const buildAction = additionalOptions && additionalOptions.buildPlatform ?
3838
additionalOptions.buildPlatform.bind(additionalOptions.buildPlatform, d.deviceInfo.platform, buildData, this.$projectData) :
39-
this.$buildController.prepareAndBuild.bind(this.$buildController, d.deviceInfo.platform, buildData, this.$projectData);
39+
this.$buildController.build.bind(this.$buildController, d.deviceInfo.platform, buildData, this.$projectData);
4040

4141
const info: ILiveSyncDeviceDescriptor = {
4242
identifier: d.deviceInfo.identifier,

0 commit comments

Comments
 (0)