refactor: fix PR comments

Author: DimitarTachev

lib/controllers/update-controller-base.ts

@@ -56,7 +56,7 @@ export class UpdateControllerBase {
 		const currentPlatformVersion = this.$platformCommandHelper.getCurrentPlatformVersion(lowercasePlatform, projectData);
 		const platformData = this.$platformsDataService.getPlatformData(lowercasePlatform, projectData);
 		if (currentPlatformVersion) {
-			return await this.$packageInstallationManager.maxSatisfyingVersionSafe(platformData.frameworkPackageName, currentPlatformVersion) || currentPlatformVersion;
+			return await this.$packageInstallationManager.getMaxSatisfyingVersionSafe(platformData.frameworkPackageName, currentPlatformVersion) || currentPlatformVersion;
 		}
 	}
 

lib/controllers/update-controller.ts

@@ -139,8 +139,8 @@ export class UpdateController extends UpdateControllerBase implements IUpdateCon
 		const devDependencies = projectData.devDependencies || {};
 		const dependencies = projectData.dependencies || {};
 		const projectVersion = dependencies[dependency] || devDependencies[dependency];
-		const maxSatisfyingTargetVersion = await this.$packageInstallationManager.maxSatisfyingVersionSafe(dependency, targetVersion);
-		const maxSatisfyingProjectVersion = await this.$packageInstallationManager.maxSatisfyingVersionSafe(dependency, projectVersion);
+		const maxSatisfyingTargetVersion = await this.$packageInstallationManager.getMaxSatisfyingVersionSafe(dependency, targetVersion);
+		const maxSatisfyingProjectVersion = await this.$packageInstallationManager.getMaxSatisfyingVersionSafe(dependency, projectVersion);
 		return maxSatisfyingProjectVersion && maxSatisfyingTargetVersion && semver.gt(maxSatisfyingTargetVersion, maxSatisfyingProjectVersion);
 	}
 
@@ -177,7 +177,7 @@ export class UpdateController extends UpdateControllerBase implements IUpdateCon
 			return false;
 		}
 
-		const maxTemplateRuntimeVersion = await this.$packageInstallationManager.maxSatisfyingVersionSafe(frameworkPackageName, templateRuntimeVersion);
+		const maxTemplateRuntimeVersion = await this.$packageInstallationManager.getMaxSatisfyingVersionSafe(frameworkPackageName, templateRuntimeVersion);
 		const maxRuntimeVersion = await this.getMaxRuntimeVersion({ platform, projectData });
 
 		return maxTemplateRuntimeVersion && maxRuntimeVersion && semver.gt(maxTemplateRuntimeVersion, maxRuntimeVersion);

lib/declarations.d.ts

@@ -98,12 +98,12 @@ interface IPackageInstallationManager {
 	getLatestVersion(packageName: string): Promise<string>;
 	getNextVersion(packageName: string): Promise<string>;
 	getLatestCompatibleVersion(packageName: string, referenceVersion?: string): Promise<string>;
-	maxSatisfyingVersion(packageName: string, versionRange: string): Promise<string>;
+	getMaxSatisfyingVersion(packageName: string, versionRange: string): Promise<string>;
 	getLatestCompatibleVersionSafe(packageName: string, referenceVersion?: string): Promise<string>;
 	getInspectorFromCache(inspectorNpmPackageName: string, projectDir: string): Promise<string>;
 	clearInspectorCache(): void;
 	getInstalledDependencyVersion(packageName: string, projectDir?: string): Promise<string>;
-	maxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string>;
+	getMaxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string>;
 }
 
 /**

lib/package-installation-manager.ts

@@ -33,21 +33,21 @@ export class PackageInstallationManager implements IPackageInstallationManager {
 			return latestVersion;
 		}
 
-		return await this.maxSatisfyingVersion(packageName, compatibleVersionRange) || latestVersion;
+		return await this.getMaxSatisfyingVersion(packageName, compatibleVersionRange) || latestVersion;
 	}
 
-	public async maxSatisfyingVersion(packageName: string, versionRange: string): Promise<string> {
+	public async getMaxSatisfyingVersion(packageName: string, versionRange: string): Promise<string> {
 		const data = await this.$packageManager.view(packageName, { "versions": true });
 
 		return semver.maxSatisfying(data, versionRange);
 	}
 
-	public async maxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string> {
+	public async getMaxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string> {
 		let maxDependencyVersion;
 		if (semver.valid(versionIdentifier)) {
 			maxDependencyVersion = versionIdentifier;
 		} else if (semver.validRange(versionIdentifier)) {
-			maxDependencyVersion = await this.maxSatisfyingVersion(packageName, versionIdentifier);
+			maxDependencyVersion = await this.getMaxSatisfyingVersion(packageName, versionIdentifier);
 		} else {
 			maxDependencyVersion = await this.$packageManager.getTagVersion(packageName, versionIdentifier);
 		}
@@ -60,7 +60,7 @@ export class PackageInstallationManager implements IPackageInstallationManager {
 		const devDependencies = projectData.devDependencies || {};
 		const dependencies = projectData.dependencies || {};
 		const referencedVersion = dependencies[packageName] || devDependencies[packageName];
-		const installedVersion = await this.maxSatisfyingVersionSafe(packageName, referencedVersion);
+		const installedVersion = await this.getMaxSatisfyingVersionSafe(packageName, referencedVersion);
 
 		return installedVersion;
 	}

test/services/webpack/webpack-compiler-service.ts

@@ -15,6 +15,8 @@ function createTestInjector(): IInjector {
 	testInjector.register("hooksService", {});
 	testInjector.register("hostInfo", {});
 	testInjector.register("logger", {});
+	testInjector.register("errors", {});
+	testInjector.register("packageInstallationManager", {});
 	testInjector.register("mobileHelper", {});
 	testInjector.register("cleanupService", {});
 

test/stubs.ts

@@ -249,15 +249,15 @@ export class PackageInstallationManagerStub implements IPackageInstallationManag
 		return Promise.resolve("");
 	}
 
-	async maxSatisfyingVersion(): Promise<string> {
+	async getMaxSatisfyingVersion(): Promise<string> {
 		return "";
 	}
 
 	async getInstalledDependencyVersion(packageName: string, projectDir?: string): Promise<string> {
 		return Promise.resolve("");
 	}
 
-	async maxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string> {
+	async getMaxSatisfyingVersionSafe(packageName: string, versionIdentifier: string): Promise<string> {
 		return Promise.resolve(versionIdentifier);
 	}
 }