fix: stop all webpack processes from sidekick when stopping the livesync

Currently when livesync is started on iOS device from sidekick, {N} CLI persist that livesync is started for iOS platform. After that if the livesync process is started on android device, {N} CLI overrides the persisted platforms and stores that the livesync is started for Android platform. However, when the livesync is stopped, {N} CLI stops it only for android platform. This means that the iOS webpack process is alive and continues to report data. This led to the multiple livesync messages when syncing the changes.

Author: Fatme

lib/controllers/run-controller.ts

@@ -38,8 +38,10 @@ export class RunController extends EventEmitter implements IRunController {
 		const projectData = this.$projectDataService.getProjectData(projectDir);
 		await this.initializeSetup(projectData);
 
-		const platforms = this.$devicesService.getPlatformsFromDeviceDescriptors(deviceDescriptors);
 		const deviceDescriptorsForInitialSync = this.getDeviceDescriptorsForInitialSync(projectDir, deviceDescriptors);
+		const newPlatforms = this.$devicesService.getPlatformsFromDeviceDescriptors(deviceDescriptors);
+		const oldPlatforms = this.$liveSyncProcessDataService.getPlatforms(projectDir);
+		const platforms = _.uniq(_.concat(newPlatforms, oldPlatforms));
 
 		this.$liveSyncProcessDataService.persistData(projectDir, deviceDescriptors, platforms);
 

lib/definitions/livesync.d.ts

@@ -492,5 +492,6 @@ declare global {
 		getAllPersistedData(): IDictionary<ILiveSyncProcessData>;
 		persistData(projectDir: string, deviceDescriptors: ILiveSyncDeviceDescriptor[], platforms: string[]): void;
 		hasDeviceDescriptors(projectDir: string): boolean;
+		getPlatforms(projectDir: string): string[];
 	}
 }

lib/services/livesync-process-data-service.ts

@@ -6,7 +6,7 @@ export class LiveSyncProcessDataService implements ILiveSyncProcessDataService {
 		this.processes[projectDir].actionsChain = this.processes[projectDir].actionsChain || Promise.resolve();
 		this.processes[projectDir].currentSyncAction = this.processes[projectDir].actionsChain;
 		this.processes[projectDir].isStopped = false;
-		this.processes[projectDir].platforms = platforms;
+		this.processes[projectDir].platforms =  platforms;
 
 		const currentDeviceDescriptors = this.getDeviceDescriptors(projectDir);
 		this.processes[projectDir].deviceDescriptors = _.uniqBy(currentDeviceDescriptors.concat(deviceDescriptors), "identifier");
@@ -30,5 +30,11 @@ export class LiveSyncProcessDataService implements ILiveSyncProcessDataService {
 	public getAllPersistedData() {
 		return this.processes;
 	}
+
+	public getPlatforms(projectDir: string): string[] {
+		const liveSyncProcessesInfo = this.processes[projectDir] || <ILiveSyncProcessData>{};
+		const currentPlatforms = liveSyncProcessesInfo.platforms;
+		return currentPlatforms || [];
+	}
 }
 $injector.register("liveSyncProcessDataService", LiveSyncProcessDataService);