Merge pull request #3998 from NativeScript/fatme/fix-bundle-validator

fix: validate correctly when `next` is written as a version of nativescript-dev-webpack in package.json

Author: Fatme

lib/helpers/bundle-validator-helper.ts

@@ -24,9 +24,12 @@ export class BundleValidatorHelper implements IBundleValidatorHelper {
 
 			if (minSupportedVersion) {
 				const currentVersion = bundlerVersionInDependencies || bundlerVersionInDevDependencies;
-				const isBundleSupported = semver.gte(semver.coerce(currentVersion), semver.coerce(minSupportedVersion));
-				if (!isBundleSupported) {
-					this.$errors.failWithoutHelp(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
+				const shouldSkipCheck = !semver.valid(currentVersion) && !semver.validRange(currentVersion);
+				if (!shouldSkipCheck) {
+					const isBundleSupported = semver.gte(semver.coerce(currentVersion), semver.coerce(minSupportedVersion));
+					if (!isBundleSupported) {
+						this.$errors.failWithoutHelp(util.format(BundleValidatorMessages.NotSupportedVersion, minSupportedVersion));
+					}
 				}
 			}
 		}

test/helpers/bundle-validator-helper.ts

@@ -79,6 +79,13 @@ describe("BundleValidatorHelper", () => {
 					currentWebpackVersion: "0.17.0-2018-09-28-173604-01",
 					minSupportedWebpackVersion: "0.17.0",
 					expectedError: null
+				},
+				{
+					name: `should not throw an error when next version of webpack is installed as ${key}`,
+					isDependency,
+					currentWebpackVersion: "next",
+					minSupportedWebpackVersion: "0.17.0",
+					expectedError: null
 				}
 			]);
 		});