Fix PR comments

Author: Fatme

lib/definitions/livesync.d.ts

@@ -383,7 +383,7 @@ interface IAndroidLivesyncTool {
 	 * @param configuration - The configuration to the socket connection.
 	 * @returns {Promise<void>}
 	 */
-	connect(configuration: ILivesyncToolConfiguration): Promise<void>;
+	connect(configuration: IAndroidLivesyncToolConfiguration): Promise<void>;
 	/**
 	 * Sends a file through the socket.
 	 * @param filePath - The full path to the file.
@@ -437,11 +437,26 @@ interface IAndroidLivesyncTool {
 	end(): void;
 }
 
-interface ILivesyncToolConfiguration {
+interface IAndroidLivesyncToolConfiguration {
+	/**
+	 * The application identifier.
+	 */
 	appIdentifier: string;
+	/**
+	 * The device identifier.
+	 */
 	deviceIdentifier: string;
-	appPlatformsPath: string; // path to platforms/android/app/src/main/assets/app/
+	/**
+	 * The path to app folder inside platforms folder: platforms/android/app/src/main/assets/app/
+	 */
+	appPlatformsPath: string;
+	/**
+	 * If not provided, defaults to 127.0.0.1
+	 */
 	localHostAddress?: string;
+	/**
+	 * If provider will call it when an error occurs.
+	 */
 	errorHandler?: any;
 }
 

lib/services/livesync/android-device-livesync-sockets-service.ts

@@ -70,13 +70,13 @@ export class AndroidDeviceSocketsLiveSyncService extends DeviceLiveSyncServiceBa
 		if (isFullSync) {
 			transferredFiles = await this._transferDirectory(deviceAppData, localToDevicePaths, projectFilesPath);
 		} else {
-			transferredFiles = await this._transferFiles(deviceAppData, localToDevicePaths, projectFilesPath);
+			transferredFiles = await this._transferFiles(localToDevicePaths);
 		}
 
 		return transferredFiles;
 	}
 
-	private async _transferFiles(deviceAppData: Mobile.IDeviceAppData, localToDevicePaths: Mobile.ILocalToDevicePathData[], projectFilesPath: string): Promise<Mobile.ILocalToDevicePathData[]> {
+	private async _transferFiles(localToDevicePaths: Mobile.ILocalToDevicePathData[]): Promise<Mobile.ILocalToDevicePathData[]> {
 		await this.livesyncTool.sendFiles(localToDevicePaths.map(localToDevicePathData => localToDevicePathData.getLocalPath()));
 
 		return localToDevicePaths;
@@ -94,15 +94,11 @@ export class AndroidDeviceSocketsLiveSyncService extends DeviceLiveSyncServiceBa
 			transferedFiles = localToDevicePaths;
 		} else {
 			const changedShasums = deviceHashService.getChnagedShasums(oldShasums, currentShasums);
-			const changedFiles = _.map(changedShasums, (hash: string, pathToFile: string) => pathToFile);
+			const changedFiles = _.keys(changedShasums);
 			if (changedFiles.length) {
 				await this.livesyncTool.sendFiles(changedFiles);
 				await deviceHashService.uploadHashFileToDevice(currentShasums);
-				transferedFiles = localToDevicePaths.filter(localToDevicePathData => {
-					if (changedFiles.indexOf(localToDevicePathData.getLocalPath()) >= 0) {
-						return true;
-					}
-				});
+				transferedFiles = localToDevicePaths.filter(localToDevicePathData => changedFiles.indexOf(localToDevicePathData.getLocalPath()) >= 0);
 			} else {
 				transferedFiles = [];
 			}

lib/services/livesync/android-livesync-library.ts

@@ -17,7 +17,7 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 	private operationPromises: IDictionary<any>;
 	private socketError: string | Error;
 	private socketConnection: IDuplexSocket;
-	private configuration: ILivesyncToolConfiguration;
+	private configuration: IAndroidLivesyncToolConfiguration;
 	private appPlatformsPath: string;
 
 	constructor(private $androidProcessService: Mobile.IAndroidProcessService,
@@ -30,7 +30,7 @@ export class AndroidLivesyncTool implements IAndroidLivesyncTool {
 			this.socketConnection = null;
 	}
 
-	public async connect(configuration: ILivesyncToolConfiguration): Promise<void> {
+	public async connect(configuration: IAndroidLivesyncToolConfiguration): Promise<void> {
 		if (!configuration.appIdentifier) {
 			this.$errors.fail(`You need to provide "appIdentifier" as a configuration property!`);
 		}