-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
**Feature request for pregeneration experiments **
After working with the pregeneration for a bit, we discovered a few things we would like to work differently.
Current behavior:
- When running with pregeneration and save_new pregeneration, KSTAR will only look into the global Network directory for pregeneration, not any place a user has generated data.
Increase places where pregen data is saved and looked for
Behavior changes:
- Add a new configuration variable, my_directory_for_pregen data. Add configuration instructions for users on how to set this. Create documentation that shows directory_for_save_precompute default is set to this configuration.
- Add a new flag in randomized_analysis that takes use_my_pregen_data. Change the flag use_pregen_data to use_global_pregen_data. Indicate in the documentation how these flags will work (if use_global_pregen_data is True, that global config directory will be checked first, then use_my_pregen_data will be checked).
- A third directory can be set using directory_for_save_precompute = "another_directory/". Indicate to users in documentation how if you only want to use this directory, you must set the other flags to False.
- Increase clarity on pregen versus precompute (maybe changing the name to be clear that precompute is for direct random datasets, not the results), also as we update the documetation, this is likely not a flag most people will set, to save the random datasets.
- Clarify in the documentation and behavior the difference between each of the modes.
- Clarify in documentation various user modes (e.g. the default user mode would have minimal information explicitly written such as num_random_experiments or the configuration directories if there's no intent to override them. Include comments for each of the flags/variables directly in the code.
Metadata
Metadata
Assignees
Labels
No labels