Skip to content

Commit e11e21b

Browse files
committed
resolve comments
1 parent bd01573 commit e11e21b

File tree

11 files changed

+13
-10
lines changed

11 files changed

+13
-10
lines changed
File renamed without changes.

quickstart/201-confidential-os-disk/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ This template deploys an Azure confidential os disk encrypted by platform key.
1212
| Name | Description |
1313
|-|-|
1414
| `location` | (Required) Azure Region in which to deploy these resources.|
15-
| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
15+
| `name_prefix` | (Required) Prefix of the resource name.|
1616

1717
## Example
1818

quickstart/201-confidential-os-disk/variables.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,5 @@ variable "location" {
55

66
variable "name_prefix" {
77
type = string
8-
default = "tftest"
98
description = "Prefix of the resource name"
109
}

quickstart/201-confidential-vm/main.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,10 @@ resource "azurerm_linux_virtual_machine" "test" {
111111
name = "${var.name_prefix}-vm"
112112
resource_group_name = azurerm_resource_group.example.name
113113
location = azurerm_resource_group.example.location
114+
115+
# Available sizes for Confidential VM can be found at: https://docs.microsoft.com/azure/confidential-computing/confidential-vm-overview
114116
size = "Standard_DC2as_v5"
117+
115118
admin_username = "azureuser"
116119
network_interface_ids = [
117120
azurerm_network_interface.example.id,
File renamed without changes.

quickstart/201-confidential-vm/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,8 @@ This template deploys an Azure confidential virtual machine with disk encrypted
1919
| Name | Description |
2020
|-|-|
2121
| `location` | (Required) Azure Region in which to deploy these resources.|
22+
| `name_prefix` | (Required) Prefix of the resource name.|
2223
| `vm_public_key` | (Required) Public key of the Virtual Machine.|
23-
| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
2424

2525
## Example
2626

quickstart/201-confidential-vm/variables.tf

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,12 @@ variable "location" {
33
description = "Location where resources will be created"
44
}
55

6-
variable "vm_public_key" {
6+
variable "name_prefix" {
77
type = string
8-
description = "Public key of the Virtual Machine"
8+
description = "Prefix of the resource name"
99
}
1010

11-
variable "name_prefix" {
11+
variable "vm_public_key" {
1212
type = string
13-
default = "tftest"
14-
description = "Prefix of the resource name"
13+
description = "Public key of the Virtual Machine"
1514
}

quickstart/201-confidential-vmss/main.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,10 @@ resource "azurerm_windows_virtual_machine_scale_set" "example" {
2121
name = "${var.name_prefix}-vmss"
2222
resource_group_name = azurerm_resource_group.example.name
2323
location = azurerm_resource_group.example.location
24+
25+
# Available skus for Confidential VMSS can be found at: https://docs.microsoft.com/azure/confidential-computing/confidential-vm-overview
2426
sku = "Standard_DC2as_v5"
27+
2528
instances = 2
2629
admin_username = "adminuser"
2730
admin_password = var.admin_password
File renamed without changes.

quickstart/201-confidential-vmss/readme.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ This template deploys an Azure confidential virtual machine scale set with guest
1515
|-|-|
1616
| `admin_password` | (Required) Admin password of the virtual machine scale set.|
1717
| `location` | (Required) Azure Region in which to deploy these resources.|
18-
| `name_prefix` | (Optional) Prefix of the resource name. Value defaults to: tftest|
18+
| `name_prefix` | (Required) Prefix of the resource name.|
1919

2020
## Example
2121

0 commit comments

Comments
 (0)